all: fix typos in comments (#28682)

chore(core,eth):fix a couple of typos
pull/28557/head^2
alex 11 months ago committed by GitHub
parent f1794ba278
commit edc864f9ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      cmd/clef/pythonsigner.py
  2. 4
      core/txpool/blobpool/blobpool.go
  3. 2
      core/txpool/blobpool/blobpool_test.go
  4. 2
      core/txpool/blobpool/metrics.go
  5. 2
      core/vm/runtime/runtime_test.go
  6. 2
      eth/downloader/downloader.go
  7. 2
      eth/downloader/resultstore.go
  8. 2
      ethclient/gethclient/gethclient_test.go
  9. 2
      p2p/rlpx/rlpx_test.go
  10. 2
      p2p/simulations/network_test.go

@ -91,7 +91,7 @@ class StdIOHandler:
{"jsonrpc":"2.0","id":20,"method":"ui_approveTx","params":[{"transaction":{"from":"0xDEADbEeF000000000000000000000000DeaDbeEf","to":"0xDEADbEeF000000000000000000000000DeaDbeEf","gas":"0x3e8","gasPrice":"0x5","maxFeePerGas":null,"maxPriorityFeePerGas":null,"value":"0x6","nonce":"0x1","data":"0x"},"call_info":null,"meta":{"remote":"clef binary","local":"main","scheme":"in-proc","User-Agent":"","Origin":""}}]} {"jsonrpc":"2.0","id":20,"method":"ui_approveTx","params":[{"transaction":{"from":"0xDEADbEeF000000000000000000000000DeaDbeEf","to":"0xDEADbEeF000000000000000000000000DeaDbeEf","gas":"0x3e8","gasPrice":"0x5","maxFeePerGas":null,"maxPriorityFeePerGas":null,"value":"0x6","nonce":"0x1","data":"0x"},"call_info":null,"meta":{"remote":"clef binary","local":"main","scheme":"in-proc","User-Agent":"","Origin":""}}]}
:param transaction: transaction info :param transaction: transaction info
:param call_info: info abou the call, e.g. if ABI info could not be :param call_info: info about the call, e.g. if ABI info could not be
:param meta: metadata about the request, e.g. where the call comes from :param meta: metadata about the request, e.g. where the call comes from
:return: :return:
""" # noqa: E501 """ # noqa: E501

@ -738,7 +738,7 @@ func (p *BlobPool) offload(addr common.Address, nonce uint64, id uint64, inclusi
} }
// Reset implements txpool.SubPool, allowing the blob pool's internal state to be // Reset implements txpool.SubPool, allowing the blob pool's internal state to be
// kept in sync with the main transacion pool's internal state. // kept in sync with the main transaction pool's internal state.
func (p *BlobPool) Reset(oldHead, newHead *types.Header) { func (p *BlobPool) Reset(oldHead, newHead *types.Header) {
waitStart := time.Now() waitStart := time.Now()
p.lock.Lock() p.lock.Lock()
@ -972,7 +972,7 @@ func (p *BlobPool) reinject(addr common.Address, txhash common.Hash) error {
} }
// SetGasTip implements txpool.SubPool, allowing the blob pool's gas requirements // SetGasTip implements txpool.SubPool, allowing the blob pool's gas requirements
// to be kept in sync with the main transacion pool's gas requirements. // to be kept in sync with the main transaction pool's gas requirements.
func (p *BlobPool) SetGasTip(tip *big.Int) { func (p *BlobPool) SetGasTip(tip *big.Int) {
p.lock.Lock() p.lock.Lock()
defer p.lock.Unlock() defer p.lock.Unlock()

@ -594,7 +594,7 @@ func TestOpenDrops(t *testing.T) {
verifyPoolInternals(t, pool) verifyPoolInternals(t, pool)
} }
// Tests that transactions loaded from disk are indexed corrently. // Tests that transactions loaded from disk are indexed correctly.
// //
// - 1. Transactions must be groupped by sender, sorted by nonce // - 1. Transactions must be groupped by sender, sorted by nonce
// - 2. Eviction thresholds are calculated correctly for the sequences // - 2. Eviction thresholds are calculated correctly for the sequences

@ -65,7 +65,7 @@ var (
pooltipGauge = metrics.NewRegisteredGauge("blobpool/pooltip", nil) pooltipGauge = metrics.NewRegisteredGauge("blobpool/pooltip", nil)
// addwait/time, resetwait/time and getwait/time track the rough health of // addwait/time, resetwait/time and getwait/time track the rough health of
// the pool and wether or not it's capable of keeping up with the load from // the pool and whether or not it's capable of keeping up with the load from
// the network. // the network.
addwaitHist = metrics.NewRegisteredHistogram("blobpool/addwait", nil, metrics.NewExpDecaySample(1028, 0.015)) addwaitHist = metrics.NewRegisteredHistogram("blobpool/addwait", nil, metrics.NewExpDecaySample(1028, 0.015))
addtimeHist = metrics.NewRegisteredHistogram("blobpool/addtime", nil, metrics.NewExpDecaySample(1028, 0.015)) addtimeHist = metrics.NewRegisteredHistogram("blobpool/addtime", nil, metrics.NewExpDecaySample(1028, 0.015))

@ -671,7 +671,7 @@ func TestColdAccountAccessCost(t *testing.T) {
for ii, op := range tracer.StructLogs() { for ii, op := range tracer.StructLogs() {
t.Logf("%d: %v %d", ii, op.OpName(), op.GasCost) t.Logf("%d: %v %d", ii, op.OpName(), op.GasCost)
} }
t.Fatalf("tescase %d, gas report wrong, step %d, have %d want %d", i, tc.step, have, want) t.Fatalf("testcase %d, gas report wrong, step %d, have %d want %d", i, tc.step, have, want)
} }
} }
} }

@ -576,7 +576,7 @@ func (d *Downloader) syncWithPeer(p *peerConnection, hash common.Hash, td, ttd *
// For non-merged networks, if there is a checkpoint available, then calculate // For non-merged networks, if there is a checkpoint available, then calculate
// the ancientLimit through that. Otherwise calculate the ancient limit through // the ancientLimit through that. Otherwise calculate the ancient limit through
// the advertised height of the remote peer. This most is mostly a fallback for // the advertised height of the remote peer. This most is mostly a fallback for
// legacy networks, but should eventually be droppped. TODO(karalabe). // legacy networks, but should eventually be dropped. TODO(karalabe).
if beaconMode { if beaconMode {
// Beacon sync, use the latest finalized block as the ancient limit // Beacon sync, use the latest finalized block as the ancient limit
// or a reasonable height if no finalized block is yet announced. // or a reasonable height if no finalized block is yet announced.

@ -142,7 +142,7 @@ func (r *resultStore) HasCompletedItems() bool {
// countCompleted returns the number of items ready for delivery, stopping at // countCompleted returns the number of items ready for delivery, stopping at
// the first non-complete item. // the first non-complete item.
// //
// The mthod assumes (at least) rlock is held. // The method assumes (at least) rlock is held.
func (r *resultStore) countCompleted() int { func (r *resultStore) countCompleted() int {
// We iterate from the already known complete point, and see // We iterate from the already known complete point, and see
// if any more has completed since last count // if any more has completed since last count

@ -450,7 +450,7 @@ func testCallContract(t *testing.T, client *rpc.Client) {
func TestOverrideAccountMarshal(t *testing.T) { func TestOverrideAccountMarshal(t *testing.T) {
om := map[common.Address]OverrideAccount{ om := map[common.Address]OverrideAccount{
{0x11}: { {0x11}: {
// Zero-valued nonce is not overriddden, but simply dropped by the encoder. // Zero-valued nonce is not overridden, but simply dropped by the encoder.
Nonce: 0, Nonce: 0,
}, },
{0xaa}: { {0xaa}: {

@ -421,7 +421,7 @@ func BenchmarkThroughput(b *testing.B) {
} }
conn2.SetSnappy(true) conn2.SetSnappy(true)
if err := <-handshakeDone; err != nil { if err := <-handshakeDone; err != nil {
b.Fatal("server hanshake error:", err) b.Fatal("server handshake error:", err)
} }
// Read N messages. // Read N messages.

@ -683,7 +683,7 @@ func triggerChecks(ctx context.Context, ids []enode.ID, trigger chan enode.ID, i
} }
} }
// \todo: refactor to implement shapshots // \todo: refactor to implement snapshots
// and connect configuration methods once these are moved from // and connect configuration methods once these are moved from
// swarm/network/simulations/connect.go // swarm/network/simulations/connect.go
func BenchmarkMinimalService(b *testing.B) { func BenchmarkMinimalService(b *testing.B) {

Loading…
Cancel
Save