52ed3570c4
cmd: migrate to urfave/cli/v2 ( #24751 )
...
This change updates our urfave/cli dependency to the v2 branch of the library.
There are some Go API changes in cli v2:
- Flag values can now be accessed using the methods ctx.Bool,
ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or
'global'.
- v2 has built-in support for flag categories. Our home-grown category
system is removed and the categories of flags are assigned as part of
the flag definition.
For users, there is only one observable difference with cli v2: flags must now
strictly appear before regular arguments. For example, the following command is
now invalid:
geth account import mykey.json --password file.txt
Instead, the command must be invoked as follows:
geth account import --password file.txt mykey.json
2 years ago
119f955686
all: remove `public` field from `rpc.API` ( #25059 )
...
all: remove public field from rpc.API
2 years ago
c7f485d9e5
internal/ethapi: add note about eth_chainId compatibility with EIP-695 ( #25168 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
647c6f2db6
internal/ethapi: always return chain id ( #25166 )
...
The error was introduced in PR #21686 , but there is no good reason to enforce sync
in this method, and it causes issues with EL/CL integration.
2 years ago
e620fa3980
eth: fix typo ( #25161 )
2 years ago
6135c688b8
eth/tracers: optimize goja buffer conversion ( #25156 )
...
This changes the []byte <-> Uint8Array conversion to use an
ArrayBuffer, avoiding inefficient copying of the slice data in Goja.
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
0f044f3433
go.mod: upgrade to latest goleveldb ( #25067 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
68420e1aa5
core: fix typo in txpool ( #25149 )
...
Fix typo in txPool truncateQueue comment
2 years ago
7c7cd410d1
eth, miner: retrieve mining state from live database ( #25139 )
...
* miner: retrieve mining state from live database
* eth/catalyst: ignore stale fcu events from cl
2 years ago
f49e298330
README,rpc: remove mention of "shh" RPC API ( #25137 )
2 years ago
f20a569265
cmd/geth: drop geth js command ( #25000 )
...
* cmd/geth: drop js command
* cmd: simplify ipc path determination for attach
* Add deprecation warning for js
* rm testdata for exec
* fix account unlock test cases
* Update cmd/geth/consolecmd.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
* fix
Co-authored-by: Martin Holst Swende <martin@swende.se>
2 years ago
10dc5dce08
all: remove concept of public/private API definitions ( #25053 )
...
* internal/ethapi: rename PublicEthereumAPI to EthereumAPI
* eth: rename PublicEthereumAPI to EthereumAPI
* internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI
* internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI
* internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI
* internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI
* internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI
* internal/ethapi: rename PublicDebugAPI to DebugAPI
* internal/ethapi: move PrivateDebugAPI methods to DebugAPI
* internal/ethapi: rename PublicNetAPI to NetAPI
* les: rename PrivateLightServerAPI to LightServerAPI
* les: rename PrivateLightAPI to LightAPI
* les: rename PrivateDebugAPI to DebugAPI
* les: rename PublicDownloaderAPI to DownloaderAPI
* eth,les: rename PublicFilterAPI to FilterAPI
* eth: rename PublicMinerAPI to MinerAPI
* eth: rename PublicDownloaderAPI to DownloaderAPI
* eth: move PrivateMinerAPI methods to MinerAPI
* eth: rename PrivateAdminAPI to AdminAPI
* eth: rename PublicDebugAPI to DebugAPI
* eth: move PrivateDebugAPI methods to DebugAPI
* node: rename publicAdminAPI to adminAPI
* node: move privateAdminAPI methods to adminAPI
* node: rename publicWeb3API to web3API
* eth,internal/ethapi: sync comments with previous renamings
2 years ago
241dd27300
trie: fix size accounting in cleaner ( #25007 )
...
Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner
2 years ago
ad15050c7f
cmd/faucet: add sepolia network support ( #25128 )
...
cmd/faucet: Add Sepolia network support to faucet
2 years ago
d39f0cce71
internal/ethapi: remove SignAndSendTransaction ( #25111 )
2 years ago
c776029c6c
cmd/faucet: more verbose message about private posts ( #25129 )
...
* cmd/faucet: Add error message for private posts
Fixes #22631
* grammar
2 years ago
21129ec838
node: make jwt tests less time-dependent ( #25120 )
2 years ago
01e5e9c2c3
tests/fuzzers/rlp: avoid very large input ( #25109 )
...
The oss-fuzz engine crashes due to stack overflow decoding a large nested
structure into a interface{}. This PR limits the size of the input data, so
should avoid such crashes.
2 years ago
ba99e19215
internal/ethapi: add comment explaining return of nil instead of error ( #25097 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
67454df08b
params: begin v1.10.20 release cycle
2 years ago
23bee16208
params: release Geth v1.10.19
2 years ago
d78d302f3d
node: add info message when JWT secret is loaded ( #25095 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
d8f963811d
cmd, params: implement Gray Glacier hard-fork (EIP-5133) ( #25088 )
...
* cmd/geth, params: implement Gray Glacier (EIP-5133)
* cmd/evm: add gray glacier tests
* params: nitpicks
* params: fixes
2 years ago
30602163d5
eth: introduce eth67 protocol ( #24093 )
...
The new protocol version removes support for GetNodeData.
See https://eips.ethereum.org/EIPS/eip-4938 for more information.
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
2 years ago
3273ad1a58
eth: add missing period at end of sentences ( #25058 )
...
eth: add missing periods on end of comments
2 years ago
bc013bc42e
all: prefer `new(big.Int)` over `big.NewInt(0)` ( #25087 )
...
minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx`
2 years ago
8cfd1214b7
common: improve pretty duration regex ( #25073 )
...
* common: improve pretty duration regex
* common: improve pretty duration regex
2 years ago
6ad620d642
cmd/ethkey: use accounts.TextHash ( #25069 )
2 years ago
1cf58c7b81
readme,eth: remove references to eth.wiki ( #25086 )
2 years ago
f74bb3a3bf
cmd/utils: update --ropsten description ( #25078 )
2 years ago
a907d7e81a
all: more linters ( #24783 )
...
This enables the following linters
- typecheck
- unused
- staticcheck
- bidichk
- durationcheck
- exportloopref
- gosec
WIth a few exceptions.
- We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there.
- The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now.
- Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention.
- The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees.
2 years ago
eb94896270
Chore: Minimal gramatical errors (signleton -> singleton) ( #25057 )
...
core: fix typos
2 years ago
3f5b5ec3e5
internal/ethapi: fix typo in comment ( #25056 )
...
typo error: keccack256 -> keccak256
2 years ago
594e321662
core/evm: fix error in comment ( #25040 )
...
Co-authored-by: Martin Holst Swende <martin@swende.se>
2 years ago
f5037185aa
core/types: improve LogForStorage and ReceiptForStorage comments ( #25032 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
6160296445
core/types: remove unused field 'td' in Block ( #25010 )
2 years ago
b60a08d2fd
eth/catalyst: remove unauthenticated 'engine' api ( #24997 )
...
Removes engine from any unauthenticated RPC service.
2 years ago
c4dab8ceca
Merge pull request #25044 from karalabe/rpc-histograms
...
rpc: swap out timer metrics to histograms
2 years ago
106a162b7c
rpc: swap out timer metrics to histograms
2 years ago
138f0d7494
p2p: use errors.Is for error comparison ( #24882 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2 years ago
41e75480df
eth, les, params: log chain config a bit saner ( #24904 )
...
Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy.
This PR converts that original data dump and converts it into a user friendly - alas multiline - log output.
2 years ago
450f5da7e1
accounts: increase parseURL test coverage ( #25033 )
...
accounts/url: add test logic what check null string to parseURL()
2 years ago
403624a4a1
p2p/discover: fix panicky test ( #25038 )
2 years ago
5e8fa1da70
tests/fuzzers/bls12381: fix blst pairing ( #25037 )
...
* tests/fuzzers/bls12381: fix blst pairing
* tests/fuzzers/bls12381: only build on gofuzz
* tests/fuzzers/bls12381: remove unused code
* tests/fuzzers/bls12381: remove unused code
2 years ago
84b327244d
accounts/abi/bind: fix duplicate field names in the generated go struct ( #24924 )
...
* accounts/abi/bind: fix duplicate field names in the generated go struct #24627
* accounts, cmd/abigen: resolve name conflicts
* ci lint, accounts/abi: remove unused function overloadedArgName
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
2 years ago
d9566e39bd
eth/filters: fix getLogs for pending block ( #24949 )
...
* eth/filters: fix pending for getLogs
* add pending method to test backend
* fix block range validation
2 years ago
7e9514b8c3
params: update ropsten terminal total difficulty block ( #25018 )
2 years ago
6b3e6cb2ab
trie: move locking into trieDB insert method ( #25030 )
...
Move locking into trieDB insert function
2 years ago
Ikko Ashimine
096daa9a7d
eth/tracers: fix typo in 4byte_tracer_legacy.js ( #25020 )
...
indentifier -> identifier
2 years ago
10da98072c
eth/api: use `hexutil.Bytes` for account range method ( #25024 )
...
eth/api: use hexutil.Bytes for range at methods
2 years ago
willian.eth
lightclient
int88
Sina Mahmoodi
ucwong
aaronbuchwald
rjl493456442
Zachinquarantine
Martin Holst Swende
Kosuke Taniguchi
Péter Szilágyi
Marius van der Wijden
lmittmann
s7v7nislands
Ivan Aracki
Gustavo Silva
Luozhu
henridf
Rajaram Gaunker
Håvard Anda Estensen
Seungbae.yu
lwh
Ikko Ashimine