52 Commits (7f2890a9be1f91368582479f171248b972b45ae3)

Author	SHA1	Message	Date
Taeik Lim	85064ed09b	all: fix 'the the' in comments (#24036)	3 years ago
Felix Lange	8a134014b4	all: add go:build lines (#23468) ... Generated by go1.17 fmt ./...	3 years ago
Martin Holst Swende	a750bf8686	crypto: fix build directives	3 years ago
Marius van der Wijden	0703ef62d3	crypto/secp256k1: fix undefined behavior in BitCurve.Add (#22621) ... This commit changes the behavior of BitCurve.Add to be more inline with btcd. It fixes two different bugs: 1) When adding a point at infinity to another point, the other point should be returned. While this is undefined behavior, it is better to be more inline with the go standard library. Thus (0,0) + (a, b) = (a,b) 2) Adding the same point to itself produced the point at infinity. This is incorrect, now doubleJacobian is used to correctly calculate it. Thus (a,b) + (a,b) == 2* (a,b) and not (0,0) anymore. The change also adds a differential fuzzer for Add, testing it against btcd. Co-authored-by: Felix Lange <fjl@twurst.com>	4 years ago
Steve Ruckdashel	6a4e730003	crypto/secp256k1: add workaround for go mod vendor (#21735) ... Go won't vendor C files if there are no Go files present in the directory. Workaround is to add dummy Go files. Fixes: #20232	4 years ago
Abd ar-Rahman Hamidi	db87223269	crypto/secp256k1: add checking z sign in affineFromJacobian (#18419) ... The z == 0 check is hit whenever we Add two points with the same x1/x2 coordinate. crypto/elliptic uses the same check in their affineFromJacobian function. This change does not affect block processing or tx signature verification in any way, because it does not use the Add or Double methods.	4 years ago
Felix Lange	23f1a0b783	crypto/secp256k1: enable 128-bit int code and endomorphism optimization (#21203) ... * crypto/secp256k1: enable use of __int128 This speeds up scalar & field calculations a lot. * crypto/secp256k1: enable endomorphism optimization	4 years ago
Kitten King	cc3ef1e4f4	cmd, crypto, eth, internals: fix Typos (#19868)	5 years ago
Shuai Qi	e57e4571d3	crypto/secp256k1: Fix invalid document link (#18297)	6 years ago
Liang ZOU	6663e5da10	all: fix various comment typos (#17748)	6 years ago
Payne	1d9d3815e5	crypto/secp256k1: remove useless code (#17728) ... `(void)data;` may cause link error on Windows.	6 years ago
Wenbiao Zheng	d1aa605f1e	all: remove the duplicate 'the' in annotations (#17509)	6 years ago
Péter Szilágyi	d9575e92fc	crypto/secp256k1: remove external LGPL dependencies (#17239)	6 years ago
Péter Szilágyi	afd8b84706	crypto/secp256k1: unify the package license to 3-Clause BSD (#17225) ... Our original wrapper code had two parts. One taken from a third party repository (who took it from upstream Go) licensed under BSD-3. The second written by Jeff, Felix and Gustav, licensed under LGPL. This made this package problematic to use from the outside. With the agreement of the original copyright holders, this commit changes the license of the LGPL portions of the code to BSD-3: --- I agree changing from LGPL to a BSD style license. Jeff --- Hey guys, My preference would be to relicense to GNUBL, but I'm also OK with BSD. Cheers, Gustav --- Felix Lange (fjl): I would approve anything that makes our licensing less complicated ---	6 years ago
kiel barry	ba975dc093	crypto: fix golint warnings (#16710)	7 years ago
David Huie	d1af4e1a9e	crypto/secp256k1: catch curve parameter parse errors (#16392)	7 years ago
Felix Lange	c6069a627c	crypto, crypto/secp256k1: add CompressPubkey (#15626) ... This adds the inverse to DecompressPubkey and improves a few minor details in crypto/secp256k1.	7 years ago
Felix Lange	e85b68ef53	crypto: add DecompressPubkey, VerifySignature (#15615) ... We need those operations for p2p/enr. Also upgrade github.com/btcsuite/btcd/btcec to the latest version and improve BenchmarkSha3. The benchmark printed extra output that confused tools like benchstat and ignored N.	7 years ago
Felix Lange	5f7826270c	all: unify big.Int zero checks, use common/math in more places (#3716) ... * common/math: optimize PaddedBigBytes, use it more name old time/op new time/op delta PaddedBigBytes-8 71.1ns ± 5% 46.1ns ± 1% -35.15% (p=0.000 n=20+19) name old alloc/op new alloc/op delta PaddedBigBytes-8 48.0B ± 0% 32.0B ± 0% -33.33% (p=0.000 n=20+20) * all: unify big.Int zero checks Various checks were in use. This commit replaces them all with Int.Sign, which is cheaper and less code. eg templates: func before(x *big.Int) bool { return x.BitLen() == 0 } func after(x *big.Int) bool { return x.Sign() == 0 } func before(x *big.Int) bool { return x.BitLen() > 0 } func after(x *big.Int) bool { return x.Sign() != 0 } func before(x *big.Int) int { return x.Cmp(common.Big0) } func after(x *big.Int) int { return x.Sign() } * common/math, crypto/secp256k1: make ReadBits public in package math	8 years ago
Felix Lange	9b0af51386	crypto: add btcec fallback for sign/recover without cgo (#3680) ... * vendor: add github.com/btcsuite/btcd/btcec * crypto: add btcec fallback for sign/recover without cgo This commit adds a non-cgo fallback implementation of secp256k1 operations. * crypto, core/vm: remove wrappers for sha256, ripemd160	8 years ago
Felix Lange	96778a1c21	crypto/secp256k1: sign with deterministic K (rfc6979) (#3561)	8 years ago
Felix Lange	e0ceeab0d1	crypto/secp256k1: update to github.com/bitcoin-core/secp256k1 @ 9d560f9 (#3544) ... - Use defined constants instead of hard-coding their integer value. - Allocate secp256k1 structs on the C stack instead of converting []byte - Remove dead code	8 years ago
Felix Lange	b9b3efb09f	all: fix ineffectual assignments and remove uses of crypto.Sha3 ... go get github.com/gordonklaus/ineffassign ineffassign .	8 years ago
Péter Szilágyi	18c77744ff	all: fix spelling errors	8 years ago
Gustav Simonsson	371871d685	parmas, crypto, core, core/vm: homestead consensus protocol changes ... * change gas cost for contract creating txs * invalidate signature with s value greater than secp256k1 N / 2 * OOG contract creation if not enough gas to store code * new difficulty adjustment algorithm * new DELEGATECALL op code	9 years ago
Felix Lange	02356b36d6	crypto/secp256k1: remove dependency on libgmp ... Turns out we actually don't need it, USE_NUM_NONE works because we also set USE_FIELD_INV_BUILTIN.	9 years ago
Gustav Simonsson	c8ad64f33c	crypto, crypto/ecies, crypto/secp256k1: libsecp256k1 scalar mult ... thanks to Felix Lange (fjl) for help with design & impl	9 years ago
Gustav Simonsson	27a50c8f4b	core/secp256k1: update libsecp256k1 Go wrapper and tests	9 years ago
Felix Lange	e344e1d490	crypto/secp256k1: drop pkgsrc paths from CFLAGS ... They cause compiler warnings for people who don't have these directories. People with pkgsrc can add the directory through CGO_CFLAGS instead.	9 years ago
Felix Lange	5159f8f649	crypto/secp256k1: raise internal errors as recoverable Go panic	9 years ago
Felix Lange	1b29aed128	crypto/secp256k1: verify recovery ID before calling libsecp256k1 ... The C library treats the recovery ID as trusted input and crashes the process for invalid values, so it needs to be verified before calling into C. This will inhibit the crash in #1983. Also remove VerifySignature because we don't use it.	9 years ago
Felix Lange	16b0bc7c3b	crypto/secp256k1: add C compiler flags for pkgsrc ... pkgsrc is a cross-platform package manager that also supports OS X.	9 years ago
Gustav Simonsson	f32fa075f1	core/secp256k1: update libsecp256k1 Go wrapper and tests	9 years ago
Gustav Simonsson	1d20b0247c	Update libsecp256k1	9 years ago
Fynn	7065ebd2ed	FreeBSD support	9 years ago
Felix Lange	bfbcfbe4a9	all: fix license headers one more time ... I forgot to update one instance of "go-ethereum" in commit 3f047be5a.	9 years ago
Felix Lange	3f047be5aa	all: update license headers to distiguish GPL/LGPL ... All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".	9 years ago
Felix Lange	ea54283b30	all: update license information	10 years ago
Gustav Simonsson	9918b6c84e	Remove the awesome, ever misunderstood entropy mixing	10 years ago
Noel Maersk	958c04e79a	doc: crypto/secp256k1 GMP dependency package name. ... Linux build documentation is mostly geared towards Ubuntu 14.04 (LTS). Appropriate package is called `libgmp-dev` there. Note that on pristine installations building `geth` with godep will fail because this header is missing. This is not documented in the top-level README, but is on the wiki: https://github.com/ethereum/go-ethereum/wiki/Installation-Instructions-for-Ubuntu#building-geth-command-line-client That page recommends `libgmp3-dev`, which ATM provides same version as `libgmp-dev`.	10 years ago
Maran	04e216319e	Adding flags to facilitate cross compiling to ARM	10 years ago
Gustav Simonsson	941f051358	libsecp256k1 #define NDEBUG	10 years ago
obscuren	50bbdfe582	Link GMP	10 years ago
Gustav Simonsson	d9b37b6da7	Update Go wrapper around libbsecp256k1	10 years ago
Gustav Simonsson	f4d4f1ccb2	Update bitcoin secp256k1 lib	10 years ago
obscuren	8f69b5c7a2	Added invalid sec key test	10 years ago
obscuren	238f39a42e	Validate seckey when generating pub key	10 years ago
Gustav Simonsson	f35d62b759	Remove secp256_rand.go and update tests	10 years ago
Gustav Simonsson	8c056aebe1	Set both key generation and ECDSA nonce to use mixed entropy ... * Move random entropy functions to new package randentropy * Add function to get n bytes entropy where up to first 32 bytes are mixed with OS entropy sources	10 years ago
obscuren	19cff8ecca	Fixed n	10 years ago