Enable even more qml linter warnings

.qmllint.ini

@@ -36,32 +36,33 @@ ResourcePath=
 #VarUsedBeforeDeclaration=warning
 #WithStatement=warning
 
-AccessSingletonViaObject=disable
+AccessSingletonViaObject=warning
-AttachedPropertyReuse=disable
+AttachedPropertyReuse=warning
+# https://bugreports.qt.io/browse/QTBUG-115439 -> set to disabled until Qt6.7
 BadSignalHandlerParameters=disable
 CompilerWarnings=disable
-Deprecated=disable
+Deprecated=warning
-DuplicatePropertyBinding=disable
+DuplicatePropertyBinding=warning
-DuplicatedName=disable
+DuplicatedName=warning
 ImportFailure=disable
-IncompatibleType=disable
+IncompatibleType=warning
-InheritanceCycle=disable
+InheritanceCycle=warning
-InvalidLintDirective=disable
+InvalidLintDirective=warning
-LintPluginWarnings=disable
+LintPluginWarnings=warning
 MissingProperty=disable
 MissingType=disable
-MultilineStrings=info
+MultilineStrings=warning
-NonListProperty=disable
+NonListProperty=warning
-PrefixedImportType=disable
+PrefixedImportType=warning
 PropertyAliasCycles=disable
-ReadOnlyProperty=disable
+ReadOnlyProperty=warning
-RequiredProperty=disable
+RequiredProperty=warning
-RestrictedType=disable
+RestrictedType=warning
-TopLevelComponent=disable
+TopLevelComponent=warning
-UncreatableType=disable
+UncreatableType=warning
 UnqualifiedAccess=disable
 UnresolvedType=disable
 UnusedImports=info
-UseProperFunction=disable
+UseProperFunction=warning
-VarUsedBeforeDeclaration=disable
+VarUsedBeforeDeclaration=warning
-WithStatement=disable
+WithStatement=warning

resources/qml/SelfVerificationCheck.qml

@@ -45,14 +45,14 @@ Item {
             Label {
                 Layout.fillWidth: true
                 Layout.margins: Nheko.paddingMedium
-                Layout.maximumWidth: (Overlay.overlay ? Overlay.overlay.width : 400) - Nheko.paddingMedium * 4
+                Layout.maximumWidth: (showRecoverKeyDialog.Overlay.overlay ? showRecoverKeyDialog.Overlay.overlay.width : 400) - Nheko.paddingMedium * 4
                 color: palette.text
                 text: qsTr("This is your recovery key. You will need it to restore access to your encrypted messages and verification keys. Keep this safe. Don't share it with anyone and don't lose it! Do not pass go! Do not collect $200!")
                 wrapMode: Text.Wrap
             }
             TextEdit {
                 Layout.alignment: Qt.AlignHCenter
-                Layout.maximumWidth: (Overlay.overlay ? Overlay.overlay.width : 400) - Nheko.paddingMedium * 4
+                Layout.maximumWidth: (showRecoverKeyDialog.Overlay.overlay ? showRecoverKeyDialog.Overlay.overlay.width : 400) - Nheko.paddingMedium * 4
                 color: palette.text
                 font.bold: true
                 horizontalAlignment: TextEdit.AlignHCenter

resources/qml/TimelineEvent.qml

@@ -14,6 +14,7 @@ EventDelegateChooser {
 
     required property bool isStateEvent
 
+    // qmllint disable required
     EventDelegateChoice {
         roleValues: [MtxEvent.TextMessage, MtxEvent.NoticeMessage, MtxEvent.ElementEffectMessage, MtxEvent.UnknownMessage,]
 
@@ -258,4 +259,5 @@ EventDelegateChooser {
             text: "Unsupported: " + typeString
         }
     }
+    // qmllint enable required
 }

resources/qml/ToggleButton.qml

@@ -5,7 +5,6 @@
 import QtQuick 2.5
 import QtQuick 2.12
 import QtQuick.Controls 2.12
-import im.nheko 1.0
 
 Switch {
     id: toggleButton

resources/qml/TypingIndicator.qml

@@ -5,7 +5,6 @@
 import QtQuick 2.9
 import QtQuick.Controls 2.3
 import QtQuick.Layouts 1.2
-import im.nheko 1.0
 
 Item {
     Layout.fillWidth: true

resources/qml/components/ReorderableListview.qml

@@ -4,7 +4,6 @@
 
 import QtQuick
 import QtQml.Models
-import im.nheko
 
 Item {
     id: root

resources/qml/delegates/Pill.qml

@@ -4,7 +4,6 @@
 
 import QtQuick 2.5
 import QtQuick.Controls 2.1
-import im.nheko 1.0
 
 Label {
     property bool isStateEvent

resources/qml/device-verification/DigitVerification.qml

@@ -5,7 +5,6 @@
 import QtQuick 2.3
 import QtQuick.Controls 2.3
 import QtQuick.Layouts 1.10
-import im.nheko 1.0
 
 ColumnLayout {
     property string title: qsTr("Verification Code")

resources/qml/device-verification/NewVerificationRequest.qml

@@ -5,7 +5,6 @@
 import QtQuick 2.3
 import QtQuick.Controls 2.3
 import QtQuick.Layouts 1.10
-import im.nheko 1.0
 
 ColumnLayout {
     property string title: flow.sender ? qsTr("Send Verification Request") : qsTr("Received Verification Request")

resources/qml/device-verification/Success.qml

@@ -5,7 +5,6 @@
 import QtQuick 2.3
 import QtQuick.Controls 2.3
 import QtQuick.Layouts 1.10
-import im.nheko 1.0
 
 ColumnLayout {
     property string title: qsTr("Successful Verification")

resources/qml/dialogs/InputDialog.qml

@@ -13,7 +13,7 @@ ApplicationWindow {
 
     property alias prompt: promptLabel.text
     property alias echoMode: statusInput.echoMode
-    property var onAccepted: undefined
+    signal accepted(text: string)
 
     modality: Qt.NonModal
     flags: Qt.Dialog
@@ -55,8 +55,7 @@ ApplicationWindow {
 
         standardButtons: DialogButtonBox.Ok | DialogButtonBox.Cancel
         onAccepted: {
-            if (inputDialog.onAccepted)
+            inputDialog.accepted(statusInput.text);
-                inputDialog.onAccepted(statusInput.text);
 
             inputDialog.close();
         }

resources/qml/dialogs/PhoneNumberInputDialog.qml

@@ -13,7 +13,7 @@ ApplicationWindow {
 
     property alias prompt: promptLabel.text
     property alias echoMode: statusInput.echoMode
-    property var onAccepted: undefined
+    signal accepted(countryCode: string, text: string)
 
     modality: Qt.NonModal
     flags: Qt.Dialog
@@ -1729,8 +1729,7 @@ ApplicationWindow {
     footer: DialogButtonBox {
         standardButtons: DialogButtonBox.Ok | DialogButtonBox.Cancel
         onAccepted: {
-            if (inputDialog.onAccepted)
+            inputDialog.accepted(numberPrefix.model.get(numberPrefix.currentIndex).i, statusInput.text);
-                inputDialog.onAccepted(numberPrefix.model.get(numberPrefix.currentIndex).i, statusInput.text);
 
             inputDialog.close();
         }

resources/qml/ui/Snackbar.qml

@@ -49,7 +49,7 @@ Popup {
 
     contentItem: Label {
         color: palette.light
-        width: Math.max(Overlay.overlay? Overlay.overlay.width/2 : 0, 400)
+        width: Math.max(snackbar.Overlay.overlay? snackbar.Overlay.overlay.width/2 : 0, 400)
         text: snackbar.currentMessage
         font.bold: true
     }