Apply suggestions from code review

pull/334/head
DeepBlueV7.X 4 years ago committed by GitHub
parent ebe0cd79d7
commit d13a1c6494
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      src/LoginPage.cpp

@ -193,7 +193,7 @@ LoginPage::loginError(const QString &msg)
auto rect = QFontMetrics(font()).boundingRect(msg); auto rect = QFontMetrics(font()).boundingRect(msg);
int width = rect.width(); int width = rect.width();
int height = rect.height(); int height = rect.height();
error_label_->setFixedHeight(qCeil(width / 200 * height)); error_label_->setFixedHeight(qCeil(width / 200) * height);
error_label_->setText(msg); error_label_->setText(msg);
} }
@ -211,7 +211,7 @@ LoginPage::isMatrixIdValid()
QRegularExpressionValidator v(QRegularExpression("@.+?:.{3,}"), this); QRegularExpressionValidator v(QRegularExpression("@.+?:.{3,}"), this);
QString s = matrixid_input_->text(); QString s = matrixid_input_->text();
int pos = 0; int pos = 0;
return v.validate(s, pos); return v.validate(s, pos) == QValidator::Acceptable;
} }
void void

Loading…
Cancel
Save