mirror
/
openzeppelin-contracts
mirror of https://github.com/OpenZeppelin/openzeppelin-contracts
2
1
Fork 1
Code Issues Releases Wiki Activity

Fix misleading comments (#2737)

Browse Source 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
pull/2739/head
Hadrien Croubois 4 years ago committed by GitHub
parent 6842518b1b
commit 1db3037808
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 4
      contracts/access/AccessControl.sol
  2. 4
      contracts/token/ERC20/extensions/ERC20Votes.sol

4
contracts/access/AccessControl.sol
Unescape View File

@ -102,7 +102,7 @@ abstract contract AccessControl is Context, IAccessControl, ERC165 {
* *
* The format of the revert reason is given by the following regular expression: * The format of the revert reason is given by the following regular expression:
* *
* /^AccessControl: account (0x[0-9a-f]{20}) is missing role (0x[0-9a-f]{32})$/ * /^AccessControl: account (0x[0-9a-f]{40}) is missing role (0x[0-9a-f]{64})$/
* *
* _Available since v4.1._ * _Available since v4.1._
*/ */
@ -130,7 +130,7 @@ abstract contract AccessControl is Context, IAccessControl, ERC165 {
* *
* The format of the revert reason is given by the following regular expression: * The format of the revert reason is given by the following regular expression:
* *
* /^AccessControl: account (0x[0-9a-f]{20}) is missing role (0x[0-9a-f]{32})$/ * /^AccessControl: account (0x[0-9a-f]{40}) is missing role (0x[0-9a-f]{64})$/
*/ */
function _checkRole(bytes32 role, address account) internal view { function _checkRole(bytes32 role, address account) internal view {
if (!hasRole(role, account)) { if (!hasRole(role, account)) {

4
contracts/token/ERC20/extensions/ERC20Votes.sol
Unescape View File

@ -107,10 +107,10 @@ abstract contract ERC20Votes is ERC20Permit {
function _checkpointsLookup(Checkpoint[] storage ckpts, uint256 blockNumber) private view returns (uint256) { function _checkpointsLookup(Checkpoint[] storage ckpts, uint256 blockNumber) private view returns (uint256) {
// We run a binary search to look for the earliest checkpoint taken after `blockNumber`. // We run a binary search to look for the earliest checkpoint taken after `blockNumber`.
// //
// During the loop, the index of the wanted checkpoint remains in the range [low, high). // During the loop, the index of the wanted checkpoint remains in the range [low-1, high).
// With each iteration, either `low` or `high` is moved towards the middle of the range to maintain the invariant. // With each iteration, either `low` or `high` is moved towards the middle of the range to maintain the invariant.
// - If the middle checkpoint is after `blockNumber`, we look in [low, mid) // - If the middle checkpoint is after `blockNumber`, we look in [low, mid)
// - If the middle checkpoint is before `blockNumber`, we look in [mid+1, high) // - If the middle checkpoint is before or equal to `blockNumber`, we look in [mid+1, high)
// Once we reach a single value (when low == high), we've found the right checkpoint at the index high-1, if not // Once we reach a single value (when low == high), we've found the right checkpoint at the index high-1, if not
// out of bounds (in which case we're looking too far in the past and the result is 0). // out of bounds (in which case we're looking too far in the past and the result is 0).
// Note that if the latest checkpoint available is exactly for `blockNumber`, we end up with an index that is // Note that if the latest checkpoint available is exactly for `blockNumber`, we end up with an index that is

Write Preview
Loading…
Cancel
Save