Improve encapsulation on ERC165 and update code style guide (#1379)

* use prefix underscore for internal state variables

* make _supportedInterfaces private

(cherry picked from commit 03dfb2965c)
pull/1474/head
Mikhail Melnik 6 years ago committed by Leo Arias
parent 10a5864fdf
commit 2c40ffa011
  1. 1
      CODE_STYLE.md
  2. 2
      contracts/introspection/ERC165.sol
  3. 6
      contracts/mocks/ERC165/ERC165InterfacesSupported.sol

@ -23,6 +23,7 @@ Any exception or additions specific to our project are documented below.
```
contract TestContract {
uint256 private _privateVar;
uint256 internal _internalVar;
}
```

@ -18,7 +18,7 @@ contract ERC165 is IERC165 {
/**
* @dev a mapping of interface id to whether or not it's supported
*/
mapping(bytes4 => bool) internal _supportedInterfaces;
mapping(bytes4 => bool) private _supportedInterfaces;
/**
* @dev A contract implementing SupportsInterfaceWithLookup

@ -21,7 +21,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
/**
* @dev a mapping of interface id to whether or not it's supported
*/
mapping(bytes4 => bool) internal supportedInterfaces;
mapping(bytes4 => bool) private _supportedInterfaces;
/**
* @dev A contract implementing SupportsInterfaceWithLookup
@ -41,7 +41,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
view
returns (bool)
{
return supportedInterfaces[interfaceId];
return _supportedInterfaces[interfaceId];
}
/**
@ -51,7 +51,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
internal
{
require(interfaceId != 0xffffffff);
supportedInterfaces[interfaceId] = true;
_supportedInterfaces[interfaceId] = true;
}
}

Loading…
Cancel
Save