Remove repeated code from ERC1967Upgrade (#2720)

pull/2724/head
Hadrien Croubois 4 years ago committed by GitHub
parent fd111df16d
commit 6f50f6e1ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      contracts/proxy/ERC1967/ERC1967Upgrade.sol

@ -65,8 +65,7 @@ abstract contract ERC1967Upgrade {
bytes memory data, bytes memory data,
bool forceCall bool forceCall
) internal { ) internal {
_setImplementation(newImplementation); _upgradeTo(newImplementation);
emit Upgraded(newImplementation);
if (data.length > 0 || forceCall) { if (data.length > 0 || forceCall) {
Address.functionDelegateCall(newImplementation, data); Address.functionDelegateCall(newImplementation, data);
} }
@ -103,8 +102,7 @@ abstract contract ERC1967Upgrade {
// Check rollback was effective // Check rollback was effective
require(oldImplementation == _getImplementation(), "ERC1967Upgrade: upgrade breaks further upgrades"); require(oldImplementation == _getImplementation(), "ERC1967Upgrade: upgrade breaks further upgrades");
// Finally reset to the new implementation and log the upgrade // Finally reset to the new implementation and log the upgrade
_setImplementation(newImplementation); _upgradeTo(newImplementation);
emit Upgraded(newImplementation);
} }
} }

Loading…
Cancel
Save