Use bytes.concat in MessageHashUtils (#4504)

audit/2023-08-07
Francisco 2 years ago committed by GitHub
parent 5ae630684a
commit d39df78f6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      .changeset/flat-bottles-wonder.md
  2. 3
      contracts/utils/cryptography/MessageHashUtils.sol

@ -2,4 +2,6 @@
'openzeppelin-solidity': minor
---
Replace some uses of `abi.encodePacked` with clearer alternatives (e.g. `bytes.concat`, `string.concat`).
Replace some uses of `abi.encodePacked` with clearer alternatives (e.g. `bytes.concat`, `string.concat`). (#4504)[https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4504]
pr: #4296

@ -46,7 +46,8 @@ library MessageHashUtils {
* See {ECDSA-recover}.
*/
function toEthSignedMessageHash(bytes memory message) internal pure returns (bytes32 digest) {
return keccak256(abi.encodePacked("\x19Ethereum Signed Message:\n", Strings.toString(message.length), message));
return
keccak256(bytes.concat("\x19Ethereum Signed Message:\n", bytes(Strings.toString(message.length)), message));
}
/**

Loading…
Cancel
Save