add missing awaits in tests

pull/674/head
Francisco Giordano 7 years ago
parent beea818f4e
commit ea1cb5c54e
  1. 4
      test/Bounty.test.js
  2. 14
      test/RBAC.test.js

@ -74,7 +74,7 @@ contract('Bounty', function (accounts) {
web3.eth.getBalance(bounty.address).toNumber()); web3.eth.getBalance(bounty.address).toNumber());
} }
}; };
bounty.createTarget({ from: researcher }); await bounty.createTarget({ from: researcher });
await awaitEvent(event, watcher); await awaitEvent(event, watcher);
}); });
}); });
@ -104,7 +104,7 @@ contract('Bounty', function (accounts) {
assert.equal(0, web3.eth.getBalance(bounty.address).toNumber()); assert.equal(0, web3.eth.getBalance(bounty.address).toNumber());
}; };
bounty.createTarget({ from: researcher }); await bounty.createTarget({ from: researcher });
await awaitEvent(event, watcher); await awaitEvent(event, watcher);
}); });
}); });

@ -45,17 +45,17 @@ contract('RBAC', function (accounts) {
.should.be.fulfilled; .should.be.fulfilled;
}); });
it('does not allow admins to call #nobodyCanDoThis', async () => { it('does not allow admins to call #nobodyCanDoThis', async () => {
expectThrow( await expectThrow(
mock.nobodyCanDoThis({ from: admin }) mock.nobodyCanDoThis({ from: admin })
); );
}); });
it('does not allow advisors to call #nobodyCanDoThis', async () => { it('does not allow advisors to call #nobodyCanDoThis', async () => {
expectThrow( await expectThrow(
mock.nobodyCanDoThis({ from: advisors[0] }) mock.nobodyCanDoThis({ from: advisors[0] })
); );
}); });
it('does not allow anyone to call #nobodyCanDoThis', async () => { it('does not allow anyone to call #nobodyCanDoThis', async () => {
expectThrow( await expectThrow(
mock.nobodyCanDoThis({ from: anyone }) mock.nobodyCanDoThis({ from: anyone })
); );
}); });
@ -69,14 +69,14 @@ contract('RBAC', function (accounts) {
}); });
it('announces a RoleAdded event on addRole', async () => { it('announces a RoleAdded event on addRole', async () => {
expectEvent.inTransaction( await expectEvent.inTransaction(
mock.adminAddRole(futureAdvisor, ROLE_ADVISOR, { from: admin }), mock.adminAddRole(futureAdvisor, ROLE_ADVISOR, { from: admin }),
'RoleAdded' 'RoleAdded'
); );
}); });
it('announces a RoleRemoved event on removeRole', async () => { it('announces a RoleRemoved event on removeRole', async () => {
expectEvent.inTransaction( await expectEvent.inTransaction(
mock.adminRemoveRole(futureAdvisor, ROLE_ADVISOR, { from: admin }), mock.adminRemoveRole(futureAdvisor, ROLE_ADVISOR, { from: admin }),
'RoleRemoved' 'RoleRemoved'
); );
@ -85,12 +85,12 @@ contract('RBAC', function (accounts) {
context('in adversarial conditions', () => { context('in adversarial conditions', () => {
it('does not allow an advisor to remove another advisor', async () => { it('does not allow an advisor to remove another advisor', async () => {
expectThrow( await expectThrow(
mock.removeAdvisor(advisors[1], { from: advisors[0] }) mock.removeAdvisor(advisors[1], { from: advisors[0] })
); );
}); });
it('does not allow "anyone" to remove an advisor', async () => { it('does not allow "anyone" to remove an advisor', async () => {
expectThrow( await expectThrow(
mock.removeAdvisor(advisors[0], { from: anyone }) mock.removeAdvisor(advisors[0], { from: anyone })
); );
}); });

Loading…
Cancel
Save