5 Commits (602d9d988498822361c4f579cff4ee7080cd7e50)

Author	SHA1	Message	Date
Balaji Pachai	3682c6575c	Added message string for require() (#1704) ... * Error handling in ERC20 and ERC721 * Added message string for require. * Fixed solhint errors. * Updated PR as per issue #1709 * changes as per #1709 and openzeppelin forum. * Changes in require statement * Changes in require statement * build pipeline fix * Changes as per @nventuro's comment. * Update revert reason strings. * Fianal update of revert reason strings. * WIP: Updating reason strings in test cases * WIP: Added changes to ERC20 and ERC721 * Fixes linting errors in *.tes.js files * Achieved 100% code coverage * Updated the test cases with shouldFail.reverting.withMessage() * Fix package-lock. * address review comments * fix linter issues * fix remaining revert reasons	6 years ago
nikeshnazareth	0dded493a0	Nonfunctional typos #1643 (#1652) ... * Add IntelliJ IDE config to .gitignore * Fix variable name in ERC20 function comments * Fix typos in Arrays function comment * Fix typos in ownership test names * Fix typo in Pausable test name * Fix grammar in Ownable function comment * Fix grammar in Crowdsale contract comment * Fix typo in Counters contract comment * Fix typo in ERC721Enumerable comment * Fix typo in ERC721PausedToken test name * Fix typo in Crowdsale function comment * Fix typo in IncreasingPriceCrowdsale function comment * Fix grammar in IncreasingPriceCrowdsale test name * Fix typo in AllowanceCrowdsale test name * Fix typo in RefundEscrow function comment * Fix typo in ERC20Migrator contract comment * Fix typos in SignatureBouncer comments * Fix typo in SignedSafeMath test name * Fix typo in TokenVesting contract comment * Move Ownable comment from @notice section to @dev The Ownable contract has a comment explaining that renouncing ownership will prevent execution of functions with the onlyOwner modifier. This commit moves that comment to the @dev section and replaces it with a description suitable for a generic user. * Clarify purpose of ERC20 transfer function * Clarify registration of ERC721Enumerable interface * Clarify purpose of AllowanceCrowdsale test * Increase specificity of inheritance comments FinalizableCrowdsale and RefundableCrowsale both have comments indicating that they are extensions of the Crowdsale contract. This commit refines those comments to the most immediate ancestor ( TimedCrowdsale and RefundableCrowdsale respectively ) * Remove unused parameter in PaymentSplitter test * Rename parameter in SignatureBouncer functions The SignatureBouncer contract has modifiers to validate the message sender is authorised to perform an action. They pass msg.sender to internal functions as the variable `account`, but the function comments refer to the variable as `sender` This commit changes the variable name to `sender` * Clarify comments in SignatureBouncer functions The SignatureBouncer has comments that use the description `sender` to refer to the variable `account`. This commit updates the comments for consistency. Maintainer Note: this reverts changes in the previous commit, which renamed the variable `account` instead.	6 years ago
Nicolás Venturo	f80c65ff67	Improve SafeMath test coverage. (#1611) ... * Improve SafeMath test coverage. * Fix linter error. * Split testCommutative into something more sane.	6 years ago
Nicolás Venturo	3e82db2f6f	Migration to truffle 5 (and web3 1.0 (and BN)) (#1601) ... * Now compiling using truffle 5. * Migrated some test files, missing BN scientific notation usage. * Now using BN time values. * Migrate ERC20 tests. * Migrate all ERC20 tests. * Migrate utils, payment and ownership tests. * All tests save ERC721 migrated. * Migrated ERC721 tests. * Fix lint errors. * Delete old test helpers. * Fix remaining crowdsale tests. * Fix signature bouncer tests. * Update how constants is used. * Compile script pre-removes the build dir. * Fix SafeMath tests. * Revert "Compile script pre-removes the build dir." This reverts commit 247e745113. * Fix linter errors. * Upgrade openzeppelin-test-helpers dependency. * Update openzeppelin-test-helpers dependency. * Define math constants globally. * Remove unnecessary ether unit. * Roll back reduced ether amounts in tests. * Remove unnecessary toNumber conversions. * Delete compile script. * Fixed failing test.	6 years ago
Francisco Giordano	a5b14f262e	Separate unsigned and signed safemath libraries (#1588) ... * separate unsigned and signed safemath libraries * update changelog entry for SignedSafeMath	6 years ago