9638ecd87a
Typo fix.
7 years ago
56735a706c
Use address(this) instead of this ( #1134 )
...
* Use address(this) instead of this
It's preferred to use `address(this)` vs `this`
* Change to address(this) vs this
7 years ago
2765350248
Prefix all parameters with underscore ( #1133 )
7 years ago
1200969eb6
Refactor/reentrancy guard gas optimization #1056 ( #1057 )
...
* optimizing ReentrancyGuard gas usage
* style fixed
7 years ago
90b98a7bef
Add pure to tokenFallback function ( #1122 )
...
Silences warning
7 years ago
16429b1522
Making visibility explicit for storage variables ( #759 )
...
* Making visibility explicit for storage variables
* Made BasicToken's variables internal.
7 years ago
ae2980b072
Add EditorConfig ( #1119 )
...
* Add EditorConfig file.
This allows users with a wide variety of editors to easily code in
OpenZeppelin's preferred 2 space indentation code style.
See https://editorconfig.org for more information.
* Eslint: Always disallow trailing space
* Eslint: Error on missing EOL at file end
7 years ago
f5b0bb3246
Added more comprehensive usage information to the Getting Started guide: ( #1089 )
...
* Added an Architecture section that speaks to the different types of contracts
* Added a Tests section that provides high-level visibility into what is used for unit testing
* Added a How To Use and Modify OpenZeppelin Contracts section
* Added development principles to the existing Security section
7 years ago
4c6575bf2f
fix: solium linting errors ( #1113 )
...
* fix: solium linting errors, fixes #1092
* fix: remove uppercase requirement
7 years ago
2f6c8b05f6
Test/assertRevert: Fix late return bug ( #1123 )
...
We now ensure that if an exception is thrown while awaiting the promise,
the exception _has_ to be a revert. We throw 'Expected revert not
received' only afterwards. This solves any problems with confusing the
word 'revert'.
Fix #775
7 years ago
567b773242
Prefer const in test files ( #1117 )
...
* Removed all instances of var.
* Sorted eslintrc rules.
* Made eslint rule severity explicit.
* Now prefering const over let.
7 years ago
6e19ed47be
fix: bounty tests, superceeds #799 ( #1112 )
...
* fix: bounty tests, superceeds #799
* fix: updates from PR notes
7 years ago
e6c15b34da
Remove chai-as-promised ( #1116 )
...
* Test: Remove chai-as-promised calls
* Test/Helpers: expectThrow accepts optional message
* NPM: Remove chai-as-promised
* Contracts/DestructibleMock: Fix lint
7 years ago
afe9113b18
fix: move RBAC to //access ( #1114 )
7 years ago
73be06412f
Remove payable from Destructible constructor ( #1107 )
...
* Destructible no longer has a payable constructor.
* Fixed linter errors.
7 years ago
23074676c4
Improved documentation for _preValidatePurchase method in Crowdsale ( #1101 )
...
* Improved documentation for _preValidatePurchase in Crowdsale
* Added newline at EOF
7 years ago
3c69cf658c
Removed JSHint (unused). ( #1088 )
7 years ago
6bd8842ab5
removed and tested unecessary gas cost ( #1017 )
...
* removed and tested unecessary gas cost
* linted
* Revert package-lock.json update.
This reverts commit 054598ce7f
7 years ago
d20d03c149
Remove redundant modifiers from safeTransferFrom ( #1029 ) ( #1030 )
7 years ago
ebd4b5e73d
decrease approval condition fix (greater than and equal to) ( #1063 )
...
* decrease approval condition fix (greater than and equal to)
* sol lint fixed
* Improved standard token decreaseApprovalTests.
7 years ago
1ecda54449
Input check sequence modification for gas efficiency ( #1043 )
...
* Update StandardToken.sol
* Slight improvement in gas efficiency
Users tend to attempt to over-spend more than they attempt to burn non-burnable tokens. If the contract checks for overspending before assuring tokens are not being burnt a slight amount of gas might be saved in the long term.
7 years ago
67b67b791e
Changed before for beforeAll, refactored Bouncer tests. ( #1094 )
...
* Changed before for beforeAll, refactored Bouncer tests.
* Fixed linter errors.
* fix: updates for SignatureBouncer tests and voucher construction
7 years ago
ce0c3274ee
made remaining public fallback functions external ( #1080 )
7 years ago
90b3050ad7
minor RBAC.sol documentation fix ( #1060 )
7 years ago
c95ea5125d
Fix MerkleProof natspec comments ( #1083 )
7 years ago
11266b0d56
Fix ReentrancyGuard comments ( #1084 )
7 years ago
45d6943913
Fix typos ( #1082 )
7 years ago
5f6d511af9
Fix typo in Crowdsale.sol ( #1035 )
7 years ago
7dbb7a8b8e
Merge branch 'release-v1.11.0'
7 years ago
3318b91697
feat: add AutoIncrementing contract ( #1023 )
...
* feat: add AutoIncrementing contract
* feat: allow multiple counters per instance
* fix: some linting errors
* feat: use recommended implementaiton
* fix: remove .only in tests
* fix: PR notes
* fix: add note about incrementing counter
7 years ago
cea2a85a42
Remove Babel ( #1074 )
...
* Test helpers no longer rely on Babel.
* Behaviours are no longer imported.
* Removed Babel dependency.
* Fixed linter errors.
7 years ago
99e4b081dc
ECRecover test should revert because of wrong calldata size ( #1050 )
...
* Assume that token is mintable.
* ECRecover test should revert because of wrong calldata size
* fix: use expectThrow
* fix: ignore failing test until solc^0.5.0
7 years ago
b120b9aff7
moved ERC165 interface IDs from ERC721 implementation files to the interface file ( #1070 )
7 years ago
cc9fa57777
v1.11.0
7 years ago
40b5594f52
Promisify web3 sync requests in tests ( #1009 )
7 years ago
4575a240f7
Create CODE_OF_CONDUCT.md ( #1061 )
...
* Create CODE_OF_CONDUCT.md
* fix: update to raw text from website rather than github's provided one
7 years ago
eb4dfea6e9
v1.11.0-rc.1
7 years ago
8fd072cf8e
Escrows ( #1014 )
...
* Added basic Escrow
* PullPayment now uses an Escrow, removing all trust from the contract
* Abstracted the Escrow tests to a behaviour
* Added ConditionalEscrow
* Added RefundableEscrow.
* RefundableCrowdsale now uses a RefundEscrow, removed RefundVault.
* Renaming after code review.
* Added log test helper.
* Now allowing empty deposits and withdrawals.
* Style fixes.
* Minor review comments.
* Add Deposited and Withdrawn events, removed Refunded
* The base Escrow is now Ownable, users of it (owners) must provide methods to access it.
7 years ago
c2ad8c3f57
Update the use of call() with selector only. ( #1033 )
7 years ago
fd253d6b8d
Fix dependency warnings ( #1053 )
...
* update package-lock generated by npm
* run npm audit fix
7 years ago
7d8e3ca8b2
Align ERC721 Receiver with current ERC721 standard. ( #1047 )
...
* Align ERC721 Receiver with current ERC721 standard.
Adds a second address field to onERC721Received
onERC721Received(address,address,uint256,bytes)
Updates the function signature to 0x150b7a02 from 0xf0b9e5ba
* Add _operator to onERC721Received
* Fix error caused by formatOnSave
* Fixed comments on ERC721Receiver
Removed "Must use 50,000 gas or less"
Corrected the function signature
7 years ago
6b37ba36a1
Remove ERC827 token. ( #1045 )
...
Implementing this token is unsafe as per comments here:
https://github.com/ethereum/EIPs/issues/827#issuecomment-397857455
7 years ago
dc1e352cc4
Don't emit Approval event when approval is cleared on transfer ( #1039 )
7 years ago
f18c3bc438
feat: initial implementation of ERC1046 ( #933 )
...
* feat: initial implementation of ERC1046
7 years ago
0047e79681
ignore truffle generated file ( #1019 )
7 years ago
74a62a1314
using SafeERC20 to implement safeTransfer in Crowdsale ( #1006 )
...
* introduced safeTransfer to Crowdsale
* Removed .node-xmlhttprequest-sync-7601
7 years ago
92b695f2fb
Fix/whitelisted crowdsale ( #981 )
...
* fix: swithc WhitelistedCrowdsale to use Whitelist.sol
* feat: refactor whitelist.sol, rbac.sol and whitelistedcrowdsale.sol
* feat: add event arg assets and update whitelist
* fix: update modifier comment and also test isWhitelisted
* fix: remove onlyWhitelisted backwards compat attempt, fix explicit inheritance
* fix: remove underscore prefix from event args
* fix: user access/Whitelist
7 years ago
ee78f67985
fixing comment - changing '_to' to '_spender' ( #1007 )
7 years ago
07020e9544
Remove redundant @dev tags ( #995 )
...
* Remove redundant @dev tags
* Remove redundant @notice tags
7 years ago
b4406d385f
Use abi.encodeWithSignature together with raw call() ( #1008 )
7 years ago
Nicolás Venturo
Roman Storm
Leo Arias
Alex
Brendan Chou
Dave Hoover
Justus Perlwitz
Doug Crescenzi
Matt Condon
Yong Zhen Yu
Amir Bandeali
zaryab
Lucas Gleba
Hoon Choi
Francisco Giordano
Leonardo
Arun Kumar
Alex Beregszaszi
Paul Barclay
Maciej Górski
Rob
chriseth