b6c5abbde5
Add `GovernorTimelockControl` address to `TimelockController` salt ( #4432 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
921ac49ccb
Fix typos in the tests ( #4452 )
2 years ago
63bfab1a0c
Enable ERC-1271 signature checks in Governor `castVoteBySig` ( #4418 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
e3adf91e50
Add state getter in TimelockController using OperationState enum ( #4358 )
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
6e21422737
Add Governor signature nonces ( #4378 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Sergei Tikhomirov <sergey.s.tikhomirov@gmail.com>
Co-authored-by: Renan Souza <renan.rodrigues.souza1@gmail.com>
2 years ago
bb64458928
Implement recommendations from 5.0 audit Phase 1A ( #4398 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
874c2d3c02
Use explicit imports ( #4399 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
2 years ago
cd48b3eab3
Add validation in Governor on ERC-721 or ERC-1155 received ( #4314 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
7cc2cbfeb5
Cleanup the structure of GovernorTimelockControl.test.js ( #4302 )
2 years ago
b425a72240
Replace revert strings with custom errors ( #4261 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
d9474327a4
Merge pull request from GHSA-5h3x-9wvq-w4m2
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
3902a410f1
Remove DOMAIN_SEPARATOR from Votes and update docs examples ( #4297 )
...
Co-authored-by: Qiwei Yang <yangqiwei97@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
15c5c71795
Remove TokenTimelock, PaymentSplitter, ERC20Snapshot, ERC20VotesComp, GovernorVotesComp ( #4276 )
2 years ago
ab2604ac5b
Add reentrancy test cases for TimelockController ( #4200 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
91df66c4a9
Implement suggestions from audit of 4.9 ( #4176 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
8d633cb7d1
Merge pull request from GHSA-93hq-5wgc-jc82
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
790cc5b65a
Add timestamp based governor with EIP-6372 and EIP-5805 ( #3934 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
5b027e517e
Add missing `await` in tests ( #4037 )
2 years ago
d625cb45ea
Include EIP-5267 discovery in EIP-712 ( #3969 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
bc6de21fe2
Create ProposalSalt event for TimelockController ( #4001 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
5e28952cbd
Add a public Governor.cancel function ( #3983 )
2 years ago
7c6e289782
Prepare tests for hardhat-exposed transition ( #3930 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
a28aafdc85
Use Prettier for JS files ( #3913 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
c1d9da4052
Use hardhat-exposed to reduce the need for mocks ( #3666 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
b0db207e4e
Fix typos in testing files ( #3899 )
2 years ago
e2d2ebc8fc
Make ERC20Votes independent from ERC20Permit ( #3816 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
887985413c
Use default admin role in TimelockController ( #3799 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
ec88e9d6aa
Add support for EOA target in Governor.relay ( #3730 )
...
(cherry picked from commit ed12acfb0a
2 years ago
ed12acfb0a
Add support for EOA target in Governor.relay ( #3730 )
2 years ago
76273ecd8e
Change admin role allocation in TimelockControler constructor ( #3722 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
(cherry picked from commit 408055dfab
2 years ago
408055dfab
Change admin role allocation in TimelockControler constructor ( #3722 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
8ea1fc87c9
Keep track of historical quorum values ( #3561 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
4135bf9707
Fix typos in timelock test ( #3461 )
...
fix typos
3 years ago
35090c1bf1
Add tests for improved coverage ( #3448 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
cd2da98d4d
Refactor magic constant in TimelocController test ( #3397 )
3 years ago
d4e6236b2b
Fix deprecated expectEvent.inLogs #3332 ( #3333 )
3 years ago
76eee35971
Improve revert message in Governor ( #3275 )
...
* Fixed typo
* fix testing and adding changelog
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
76fca3aec8
Add ERC721 and ERC1155 receiver support in Governor, Timelock ( #3230 )
...
* add ERC721 and ERC1155 receiver support in Governor, Timelock and MinimalForwarder (#3174 )
* revert the nft receiver hooks from MinimalForwarder and linting updates
* add ERC165 support & simplify test
* add changelog entry
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
faf5820f03
Fix many spelling errors ( #3274 )
3 years ago
6a5bbfc4cb
Refactor governor testing ( #3194 )
...
* starting a governor test refactor
* improve governor tests
* refactor compatibility tests using the governor helper
* improve governor helper
* improve governor helper
* refactor governor tests
* refactor testing
* fix testing (still TODO)
* fix tests
* fix tests
* fix spelling
* use different instances of GovernorHelper
* add vote with params support
* coverage
* simplify ERC165 helper
* remove unused proposal argument
* refactor setProposal
* lint
* refactor setProposal return values
* add a data default value
* improve proposal reconstruction and storage in helper
* proposal object refactoring
* lint
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
8b162e39b5
Add a canceller role to the TimelockController ( #3165 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
fd07cc6290
Extend Governor with parameterized votes ( #3043 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
af7ec04b78
Improve security of the onlyGovernance modifier ( #3147 )
...
* add a protection mechanism to prevent relaying transaction that are not
part of an execute operation
* more accurate relay authorization
* force reset the relay authorizations after executions
* refactor of the onlyGovernor modifier
* only whitelist when executor is not governor itself
* fix lint
* add private function for call permission management
* use deque
* fix lint
* remove unecessary dependency
* remove unecessary dependency
* comment rephrasing
* Update contracts/governance/Governor.sol
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
* cache keccak256(_msgData())
* use Context
* lint
* conditionnal clear
* add test to cover queue.clear()
* lint
* write more extended docs for onlyGovernance
* add changelog entry
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
c366de3626
Fix encoding of signature+calldata in GovernorCompatibilityBravo ( #3100 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
b42b05311b
Add ERC721Votes for NFT-based governance ( #2944 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien@openzeppelin.com>
3 years ago
abf6024faf
Add a governor module to protect against late quorum ( #2973 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
6089f11c2f
Add a relay mechanism in the governor ( #2926 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
a57e638f57
Improve GovernorTimelockControl.state() to detect direct cancel ( #2977 )
3 years ago
b12af48a7d
Add Governor module for governance-settable parameters ( #2904 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
abeb0fbf5c
Delay the Pending state until strictly after proposal.voteStart ( #2892 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Ernesto García
Pierre Grimaud
Renan Souza
Francisco
Claudia Barcelo
Hadrien Croubois
JulissaDantes
Andrew Fleming
onlineSoftwareDevOK
Niccolò Petti
Mihir Wadekar
Ashwin Yardi
Pandapip1
Ben DiFrancesco