Nicolás Venturo
9faebb5365
Added makeInterfaceId tests. ( #1530 )
6 years ago
Nicolás Venturo
714ab21a6e
Added mocha-no-only ESlint plugin. ( #1529 )
6 years ago
Nicolás Venturo
8dae261d20
Deleted transactionMined (unused). ( #1527 )
6 years ago
Nicolás Venturo
6fd0010325
Moved advanceBlock to time. ( #1523 )
...
* Added advanceBlock to time, moved tests around.
* Removed the standalone advanceBlock.
* Removed the 'id' field
* Fixed linter error.
* Removed the 'latest' test, since it only works if time hasn't been fast-forwarded.
* Removed .only directive.
6 years ago
Nicolás Venturo
7ef2730506
Approval events on transferFrom and burnFrom ( #1524 )
...
* transferFrom now emits an Approval event, indicating the updated allowance.
* Updated burnFrom to also emit Approval.
* Added notices about the extra Approval events.
6 years ago
Nicolás Venturo
6407d7818d
Added time helper tests. ( #1521 )
...
* Added time tests.
* Minor improvements.
6 years ago
Nicolás Venturo
c2de8ffd14
Now testing events in constructors! ( #1511 )
...
* Added inTransaction tests.
* Added expectEvent.inConstructor.
* Changed inTransaction, removed decodeLogs.
* Flipped comparison to improve the error message.
* Improved expectEvent tests.
* Migrated tests to use expectEvent.
* Added roles constructor tests.
* Fixed linter errors.
* Made lodash a dev dependency.
* Added more inLogs tests.
* Update expectEvent.test.js
* Removed lodash.
* Moved role constructor tests to public role behavior.
* Revert "Flipped comparison to improve the error message."
This reverts commit 438c57833d
.
* Replaced chai-as-promised with shouldFail.
6 years ago
Nicolás Venturo
f0e12d5301
ether and shouldFail tests ( #1513 )
...
* Added ether tests.
* Added shouldFail base function and tests.
* Updated test descriptions.
* Reduced gas limit on out-of-gas tests.
6 years ago
Nicolás Venturo
21ed6bee25
Travis migration ( #1517 )
...
* Rolled back Travis stages
* Rolled back the rolled-back changes.
* Renamed jobs, coverage can no longer fail.
* Cleaned up the yaml file a bit.
* Updated coveralls badge.
6 years ago
Nicolás Venturo
b9793abec6
balanceDifference tests and application ( #1514 )
...
* Added balanceDifference tests.
* Added balanceDifference tests.
* Now using balanceDifference in all (most) tests.
* Fixed typo.
6 years ago
Nicolás Venturo
5471fc808a
Updated code style to 4 space indentation and 120 characters per line. ( #1508 )
...
* Updated code style to 4 spaces and 120 max characters per line.
* Update contracts/token/ERC721/ERC721Pausable.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Update contracts/token/ERC721/IERC721.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
6 years ago
Alexander Kochetkov
281338409b
Test description fix in ERC20Pausable.test.js ( #1501 )
...
Small change in test description, should be "allows to approve..." instead of "allow to transfer..." in approve section, where test actualy try to approve, not to transfer.
6 years ago
Francisco Giordano
a833c4b4ee
Merge branch 'release-v2.0.0'
6 years ago
Nicolás Venturo
bb6a24e6aa
Renamed roles private variables to adhere to code style. ( #1507 )
6 years ago
William Entriken
83bc045a56
Remove extraneous quantity check, fixes #1454 ( #1455 )
6 years ago
Brendan Chou
6363a776f7
Remove redundant require statements ( #1409 )
...
* Remove redundant require statements
Now that SafeMath uses require, the require statements are redundant. They were also previously inconsistent because they were only included in some functions, but not others
* Update ERC20.sol
6 years ago
Leo Arias
f72c79d54a
Add the step to delete the build dir to the RELEASE notes ( #1467 )
6 years ago
Hao (Alan) Tang
32bc7a6fe5
add an address typecast to this per issue #1457 ( #1471 )
6 years ago
LaimeJesus
1186520617
add improvement in simpletoken example #1458 ( #1473 )
...
* add improvement in simpletoken example #1458
* fix not calling decimals get function in initial supply
6 years ago
Aniket
b5892a2b5e
SafeMath Test Coverage Improved ( #1477 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4
.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1386
* Update SafeMath.test.js
6 years ago
Aniket
4f356e35a9
The beneficiary parameter of claimRefund is replaced with refundee ( #1481 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4
.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1456
6 years ago
Hao (Alan) Tang
79eb94d3cd
fix ERC20.sol#L174 and ERC20.sol#L187 should be casted to an address type. ( #1470 )
6 years ago
Hao (Alan) Tang
18552a8d5f
Fix/add comment erc721 burnable #1464 ( #1469 )
...
* fix Add a comment to ERC721Enumerable #1465
* fix Add comments to ERC721Burnable #1464
6 years ago
Leo Arias
06e265b38d
Release v2.0.0
6 years ago
Leo Arias
7789814606
Release candidate v2.0.0-rc.4
6 years ago
Nicolás Venturo
643ac86d0a
Improved some ERC721 internal shenanigans ( #1450 )
...
* Made _clearApproval private, added clarifying comments in _addTokenTo and _removeTokenFrom.
* Added approval information.
(cherry picked from commit 8204f6a71f
)
6 years ago
Leo Arias
ae339333d7
Add warning about trading tokens before refundable crowdsale goal is met ( #1452 )
...
This attack was reported in https://github.com/OpenZeppelin/openzeppelin-solidity/issues/877
(cherry picked from commit 80458ebc72
)
6 years ago
Nicolás Venturo
1a4009f817
Crowdsale.buyTokens is now nonReentrant. ( #1438 )
...
(cherry picked from commit 6d415c508b
)
6 years ago
Nicolás Venturo
ecae7608f9
InitialRate must be strictly larger than finalRate. ( #1441 )
...
(cherry picked from commit a936cbf5fb
)
6 years ago
Nicolás Venturo
47b5d61844
Fixed how allowance crowdsale checks remaining tokens. ( #1449 )
...
(cherry picked from commit 1ac1ac984e
)
6 years ago
Nicolás Venturo
984fe23a46
Deleted unnecessary import. ( #1437 )
...
* Deleted unnecessary import.
* Added back SafeMath.
* Removed another unnecessary import.
(cherry picked from commit bbe804a14b
)
6 years ago
Nicolás Venturo
5cdf4de1f6
Made SampleCrowdsale a bit clearer. ( #1448 )
6 years ago
Nicolás Venturo
a9bffb3787
Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. ( #1447 )
...
(cherry picked from commit 5bb865218f
)
6 years ago
Nicolás Venturo
6e53c4e129
Crowdsale docs improvements. ( #1446 )
...
* Added a small Crowdsale fallback gas warning.
* Fixed a couple typos.
(cherry picked from commit 94692acb14
)
6 years ago
Nicolás Venturo
95411da289
Renamed internal ERC721 check function. ( #1445 )
...
(cherry picked from commit 384dff9abe
)
6 years ago
Nicolás Venturo
e237530538
Made tokenURI external, as per the spec. ( #1444 )
...
(cherry picked from commit 5bf3907862
)
6 years ago
Nicolás Venturo
0ead40ae03
ERC20Capped now capps _all_ minting, even internal calls. ( #1443 )
...
(cherry picked from commit c8220aeea8
)
6 years ago
Nicolás Venturo
2e848e12d1
IncPriceCrowdsale consistently returns 0 outside of the crowdsale window. ( #1442 )
...
(cherry picked from commit 9155bfe27f
)
6 years ago
Nicolás Venturo
6e055019d4
Closing time must be strictly after opening time. ( #1440 )
...
(cherry picked from commit 1c5f16ae26
)
6 years ago
Nicolás Venturo
5ee55c4af3
Internal crowdsales ( #1439 )
...
* Made some internal crowdsale methods internal.
* Made all Crowdsale constructors internal.
(cherry picked from commit d9fdffe88e
)
6 years ago
Aniket
1b27b4bb34
Improved SafeERC20 allowance handling ( #1407 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4
.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* allowance methods in library
* Improved SafeERC20 tests.
* Fixed test coverage.
(cherry picked from commit 315f426f5c
)
6 years ago
Nicolás Venturo
4115686b4f
TokenVesting improvements ( #1431 )
...
* Improved TokenVesting events.
* Added extra checks to TokenVesting.
* Renamed the events.
* Fixed linter error.
* Fixed a test that failed to cover a require.
* Renamed TokensRevoked to TokenVestingRevoked.
(cherry picked from commit 67dac7ae99
)
6 years ago
cardmaniac992
6db4f0bc8f
SplitPayment improvements ( #1417 )
...
* Renamed file, added events and set _addPayee to private
* unwanted file
* adjusted test
* adjusted test
* PaymentReceived event added
* Added event testing.
* Fix static tests
(cherry picked from commit a07499796a
)
6 years ago
Christopher Glisch
5f3ecd9c64
Added address of pauser/unpauser in events ( #1410 )
...
* Added address of pauser/unpauser in events
* Added the account to the Pausable tests.
(cherry picked from commit fcab9c89f2
)
6 years ago
Aniket
c126e3e81a
Events added to Secondary ( #1425 )
...
* Update contracts/ownership/Secondary.sol
* Update Secondary.sol
* Update Secondary.test.js
* Update Secondary.test.js
* Update Secondary.sol
(cherry picked from commit cbe414864f
)
6 years ago
Nicolás Venturo
ab932e1873
Added leading underscore to internal functions, renamed supportsInterfaces. ( #1435 )
...
(cherry picked from commit 0231fac514
)
6 years ago
Nicolás Venturo
4394107660
Added replay attack notice to SignatureBouncer. ( #1434 )
...
(cherry picked from commit ff0c048ad9
)
6 years ago
Nicolás Venturo
422b42bb6a
Made some inherit-only contracts internal. ( #1433 )
...
* Made some inherit-only contracts internal.
* Added OwnableMock.
(cherry picked from commit 96d6103e0b
)
6 years ago
Nicolás Venturo
3b34436b44
Made some TokenVesting public functions private. ( #1427 )
...
* Made some TokenVesting public functions private.
* Fixed linter error.
(cherry picked from commit df3c113711
)
6 years ago
Nicolás Venturo
c5a8680a9c
Moved Escrows into an escrow subdirectory, improved docs. ( #1430 )
...
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
(cherry picked from commit f3df2dab3d
)
6 years ago