Francisco Giordano
af55a843e3
fix pr number in changelog
6 years ago
Nicolás Venturo
67bca857ee
Revert Solidity version bump. ( #1729 )
6 years ago
Francisco Giordano
2769d0d2c7
update links in documentation setup description
6 years ago
Nicolás Venturo
9d868ee846
Add revert reasons changelog entry.
6 years ago
Nicolás Venturo
2f8e844514
Fix remaining revert reasons.
6 years ago
Balaji Pachai
3682c6575c
Added message string for require() ( #1704 )
...
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
6 years ago
Francisco Giordano
4a0a67b04c
make some updates on the get started guide ( #1725 )
6 years ago
Nicolás Venturo
97a9ca5681
Add a vault to PostDeliveryCrowdsale. ( #1721 )
...
* Add a vault to PostDeliveryCrowdsale.
* Add changelog entry.
* Apply suggestions from code review
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Rename TokenVault.
* add solhint ignore directive
6 years ago
Nicolás Venturo
19c7414052
Bump minimum Solidity version to 0.5.7 ( #1724 )
...
* Bump Solidity version to 0.5.7
* Add changelog entry.
6 years ago
Nicolás Venturo
5e46cf6de4
Fix linter error.
6 years ago
Francisco Giordano
ed5652b0aa
New documentation setup ( #1708 )
...
* initial docsite setup
* switch from pushd to cd
* install and set up solidity-docgen
* use the docsite branch next for now
* make it clear that env var is a repository
* add a clarifying comment about a relative path
* change relative to absolute path in docsite script
* add docgen script
* add first few READMEs for contract documentation
* update solidity-docgen
* add docsite as dependency and adjust script
* update openzeppelin-docsite
* update solidity-docgen
* remove dummy text
* update docgen and docsite
* update openzeppelin-docsite
* add netlify.toml
* udpate tokens guide for 2.2
* add DOCUMENTATION.md
* Update docs/learn-about-utilities.md
Co-Authored-By: frangio <frangio.1@gmail.com>
* fix PaymentSplitter docs wording
* update solidity-docgen
* add missing ERC20 contracts
* update solidity-docgen
* trigger deploy with cleared cache
* update solidity-docgen
* update openzeppelin-docsite
* remove travis docs setup
* update openzeppelin-docsite
* switch to published solidity-docgen
6 years ago
Nicolás Venturo
412cdfd0be
Release automation ( #1720 )
...
* Create autoamtic release script.
* Add changelog update date script.
* Improve release scripts.
* Apply suggestions from code review
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Apply suggestions from code review
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Remove moment dependency.
6 years ago
Francisco Giordano
59f03f00c5
Fix stalebot exempt labels
6 years ago
Nicolás Venturo
ea59f86cdf
Update stalebot wording and timing. ( #1722 )
6 years ago
Balaji Pachai
0df0e1b250
Fixes/Improves constants inline documentation. ( #1707 )
...
* Fixes/Improves constants inline documentation.
* Fixed solhint error.
* Moved the comment before the variable
6 years ago
Bertrand Masius
5a2b349992
Feature/erc777 #1159 ( #1684 )
...
* IERC777 from specs, constants returned, up to defaultOperators. (#1159 )
* IERC777 oprarator approvals (#1159 )
* ERC777 oprarator approvals fixes and tests
* IERC777 send and receive with ERC820 (#1159 )
* ERC777 Add burn functions and fix send functions (#1159 )
* ERC777 Make expectEvent compatible with web3.js 1.0 (#1159 )
* ERC777 Add ERC820 deploy script (#1159 )
* ERC777 Complete implementation of ERC777 (#1159 )
This implementation conforms to the current EIP
* ERC777 Update ERC820 Registry contract to final version (#1159 )
* ERC777 Move contracts to 'drafts' folder (#1159 )
* ERC777: Update to ERC1820 registry and linter error fix (#1159 )
* ERC777: implement recent changes of EIP777 (#1159 )
* ERC777 Fix formatting (#1159 )
* ERC777 Update to solc 0.5.2 (#1159 )
* ERC777 Fix travis CI errors (#1159 )
* ERC777 Fix linter errors again... (#1159 )
* ERC777 Fix unit test (#1159 )
* ERC777 Fix unit test again (#1159 )
* Remove extra newlines.
* Rename ERC777Base to ERC777.
* Remove 'Token' from contract names.
* Replace ops for operators.
* Move operator check out of _send.
* Remove ERC777Burnable.
* Remove ERC1820Client, now using the interface directly.
* Minor internal refactors in contracts.
* Delete extra test helpers.
* Simplified tests.
* Add basic 777 tests.
* Add granularity send test.
* Add first operator send tests.
* Add burn tests.
* Refactor send and burn tests.
* Improve send burn refactor.
* Greatly improve test module.
* Burn instead of send removed tokens.
* Add operator tests.
* Improve send tests under changing operators.
* Refactor and merge send and burn tests.
* Add missing and not-implemented tests.
* Make _burn private.
* Fix typo.
* Greatly improve tokensToSend tests.
* Refactor hook tests.
* Fix hook tests.
* Update openzeppelin-test-helpers and ERC1820 address.
* Fix natspec indentation.
* Make interface functions external.
* Remove redundant private revoke and authorize functions.
* Improved readability of if statement.
* Remove unnecessary asserts.
* Add non-one granularity test.
* Fix hook call order in _mint.
* Fix _mint not reverting on failure to implement tokensReceived.
* Remove special case in operatorFn when from is 0.
* Refactor ERC777SenderMock.
* Add tokensReceived tests.
* switch to updated ganache-cli-coverage fork
* Fix linter errors.
* Add mint tests.
* Fix linter errors.
* Fix tests.
* Update test/drafts/ERC777/ERC777.test.js
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Add changelog entry.
6 years ago
Prince Sinha
963f1eb35b
removed unnecessary require and renaming of null to zero ( #1717 )
...
* removed unnecessary require
* build pipeline fix
* kept as it is
* Added require
6 years ago
ckshei
bbe0eefd9f
removing unused variables ( #1719 )
...
* removing unused variables
* undeleting the _
6 years ago
ckshei
19c705d928
Fix/rename anyone account #1357 ( #1718 )
...
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* changing anyone to other
* changing anyone to other
6 years ago
Francisco Giordano
d45f0c89db
Update copyright notice
6 years ago
Nicolás Venturo
1ebeef7ffd
Remove unnecessary SLOAD. ( #1715 )
6 years ago
Francisco Giordano
b353f7e18c
Add more extensive documentation to PaymentSplitter ( #1713 )
...
* Update PaymentSplitter.sol
* add back private function docs
* add non-zero address requirement
* add comprehensive contract-level docs
* use capital E for Ether
6 years ago
Nicolás Venturo
92e68e3aaa
Revert "Add WIP bot."
...
This reverts commit 07fc8c731a
.
6 years ago
Nicolás Venturo
07fc8c731a
Add WIP bot.
6 years ago
Vittorio Minacori
81e36d2e74
Fix from account in remove public role behaviors ( #1710 )
6 years ago
Nicolás Venturo
35d8e860ad
Remove unused files ( #1698 )
...
* Remove unused dependencies.
* Remove unused mock contracts.
6 years ago
Francisco Giordano
8b44efd035
add note about Counters rename in changelog ( #1703 )
6 years ago
J Quinn
3cb4a00fce
Added basic punctuation to @dev docs ( #1697 ) ( #1700 )
...
* Added basic punctuation to @dev docs (#1697 )
* add missing uppercase
6 years ago
Nicolás Venturo
c008f1f0c6
Exclude on-hold PRs and issues on stalebot. ( #1696 )
6 years ago
Franco Zeoli
dc5ca8edc4
Edit Ethereum dev framework links in README. ( #1695 )
...
Added Buidler.
6 years ago
Nicolás Venturo
7ccd224567
Update SafeERC20.sol ( #1693 )
6 years ago
Nicolás Venturo
cf7375d6b8
Update openzeppelin-test-helpers dependency.
6 years ago
Nicolás Venturo
308a4c9907
Draft EIP 1820 ( #1677 )
...
* Add barebones EIP1820 support.
* Update openzeppelin-test-helpers dependency to have ERC1820 support.
* Add tests for ERC1820.
* Improve inline documentation.
* Add changelog entry.
* Update test-helpers, refactor tests to use new helpers.
* Rename ERC1820 to ERC1820Implementer.
* Improve implementer docstring.
* Remove _implementsInterfaceForAddress.
* update openzeppelin-test-helpers to 0.2.0
* Update contracts/drafts/ERC1820Implementer.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Fix how solidity coverage is run to allow for free events.
* Fix coverage testing script.
6 years ago
Nicolás Venturo
269e096c5a
Remove unused return variables. ( #1686 )
6 years ago
Nicolás Venturo
edfce5a3dd
Add probot/stale to the repo. ( #1681 )
6 years ago
Jochen Brüggemann
ab14debb08
Make waiting for ganache to launch more robust. ( #1683 )
6 years ago
Nicolás Venturo
40d2eb3007
Merge branch 'release-v2.2.0'
6 years ago
Nicolás Venturo
9ed1b44865
Release v2.2.0
6 years ago
Nicolás Venturo
7aaf15be59
Add v2.2.0 release date.
6 years ago
Nicolás Venturo
2a37b09cf6
Improve test script. ( #1675 )
6 years ago
Nicolás Venturo
29fa0a4ce5
Add API stability doc link. ( #1672 )
...
* Add API stability doc link.
* Update README.md
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
6 years ago
Nicolás Venturo
06f7266a6e
Replace mentions of Slack for forum links. ( #1671 )
...
* Replace mentions of Slack for forum links.
* make forum lowercase
6 years ago
Nicolás Venturo
4c706480e5
Fix typo in ERC20Snapshot. ( #1670 )
6 years ago
nikeshnazareth
4dd8575bb6
Improve erc165 testing #1203 ( #1666 )
...
* Rename variable from thing to contractUnderTest
* Compute function signatures in ERC165 interfaces
The ERC165 tests currently precompute some known interface ids.
This commit extracts the interfaces into a separate object and
precomputes the individual function signatures.
This will be useful to identify contracts that support an interface
but do not implement all of the corresponding functions.
* Add tests for ERC165 interface implementations
The ERC165 tests confirm that contracts claim to support
particular interfaces ( using the supportsInterface method )
This commit extends those tests to confirm that the corresponding
functions are included in the contract ABI.
It also rewords the existing test names in order to group the
implementation tests with the corresponding interface tests.
* Remove obsolete ERC721Exists interface constant
6 years ago
Nicolás Venturo
9c69df5962
Fix changelog entry.
6 years ago
Nicolás Venturo
1e5295d304
Release candidate v2.2.0-rc.1
6 years ago
Nicolás Venturo
61c4318c33
Reorder 2.2.0 changelog entries.
6 years ago
Thomas Bocek
79dd498b16
Signature Malleability: ( #1622 )
...
* Transaction Malleability:
If you allow for both values 0/1 and 27/28, you allow two different
signatures both resulting in a same valid recovery. (r,s,0/1) and
(r,s,27/28) would both be valid, recover the same public key and sign
the same data. Furthermore, given (r,s,0/1), (r,s,27/28) can be
constructed by anyone.
* Transaction Malleability:
EIP-2 still allows signature malleabality for ecrecover(), remove this
possibility and force the signature to be unique.
* Added a reference to appendix F to the yellow paper and improved
comment.
* better test description for testing the version 0, which returns
a zero address
* Check that the conversion from 0/1 to 27/28 only happens if its 0/1
* improved formatting
* Refactor ECDSA code a bit.
* Refactor ECDSA tests a bit.
* Add changelog entry.
* Add high-s check test.
6 years ago
Nicolás Venturo
547a5f242a
Add extcodesize check to SafeERC20. ( #1662 )
...
* Add extcodesize check to SafeERC20.
* Clarify some comments.
* Replace inline assembly with Address.sol.
6 years ago
Anton Bukov
352ec94579
Add TimedCrowdsale::_extendTime ( #1636 )
...
* Add TimedCrowdsale::_extendTime
* Add tests for TimedCrowdsale extending method
* Reverse event arguments order
* Rename method argument
* Refactor TimedCrowdsale test
* Simplify TimedCrowdsaleImpl
* Fix extendTime method behaviour to deny TimedCrowdsale re-opening after it was ended
* Append chengelog
* Update CHANGELOG.md
Co-Authored-By: k06a <k06aaa@gmail.com>
* Update contracts/crowdsale/validation/TimedCrowdsale.sol
Co-Authored-By: k06a <k06aaa@gmail.com>
* Improve tests
6 years ago