Ernesto García
70578bbb44
Allow Initializable versions greater than 256 ( #4460 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Hadrien Croubois
9bb8008c23
Access Manager ( #4416 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
Hadrien Croubois
21716722ad
Remove GovernorCompatibilyBravo and add simpler GovernorStorage ( #4360 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
Ernesto García
121be5dd09
Make `TransparentUpgradeableProxy` deploy its `ProxyAdmin` and optimize proxy interfaces ( #4382 )
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Eric Lau <ericglau@outlook.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
Francisco
84db204a41
Rename rounding modes and complete with fourth ( #4455 )
...
Co-authored-by: ernestognw <ernestognw@gmail.com>
2 years ago
Pierre Grimaud
921ac49ccb
Fix typos in the tests ( #4452 )
2 years ago
Francisco
4bac6fa310
Improve custom error helper when there is no match ( #4437 )
2 years ago
Ernesto García
63bfab1a0c
Enable ERC-1271 signature checks in Governor `castVoteBySig` ( #4418 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Renan Souza
e3adf91e50
Add state getter in TimelockController using OperationState enum ( #4358 )
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
Ernesto García
6e21422737
Add Governor signature nonces ( #4378 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Sergei Tikhomirov <sergey.s.tikhomirov@gmail.com>
Co-authored-by: Renan Souza <renan.rodrigues.souza1@gmail.com>
2 years ago
Hadrien Croubois
dac2457a80
Improve customError testing ( #4376 )
2 years ago
Ernesto García
b425a72240
Replace revert strings with custom errors ( #4261 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Hadrien Croubois
0f10efe232
Remove code in preparation for v5.0 ( #4258 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Francisco
fa112be682
Add AccessManager contracts ( #4121 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
Yamen Merhi
53235263a3
Implement `0x00` version of EIP-191 in ECDSA Library ( #4063 )
2 years ago
Francisco
adb861fb3b
Change Governor.cancel to receive all parameters ( #4056 )
2 years ago
Francisco
4ff538af58
Fix flaky timestamp tests ( #4046 )
2 years ago
Hadrien Croubois
790cc5b65a
Add timestamp based governor with EIP-6372 and EIP-5805 ( #3934 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
Hadrien Croubois
d625cb45ea
Include EIP-5267 discovery in EIP-712 ( #3969 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Hadrien Croubois
5e28952cbd
Add a public Governor.cancel function ( #3983 )
2 years ago
Hadrien Croubois
30c3c6c16e
Clean up after merging master into next-v5.0 ( #3956 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
Hadrien Croubois
7c6e289782
Prepare tests for hardhat-exposed transition ( #3930 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
Francisco
a28aafdc85
Use Prettier for JS files ( #3913 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
Hadrien Croubois
c1d9da4052
Use hardhat-exposed to reduce the need for mocks ( #3666 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
JulissaDantes
bc8f442d00
Remove admin and implementation getters from TransparentUpgradeableProxy ( #3820 )
...
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
Hadrien Croubois
7c75b8aa89
Add a SafeERC20:safePermit function ( #3280 )
3 years ago
Hadrien Croubois
051cc9e446
Revert unwanted breaking change in the Clones library ( #3456 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
35090c1bf1
Add tests for improved coverage ( #3448 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
5e00787199
ERC4626 ( #3171 )
3 years ago
Hadrien Croubois
668a648bc6
Add utilities for CrossChain messaging ( #3183 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Pandapip1
faf5820f03
Fix many spelling errors ( #3274 )
3 years ago
Hadrien Croubois
6a5bbfc4cb
Refactor governor testing ( #3194 )
...
* starting a governor test refactor
* improve governor tests
* refactor compatibility tests using the governor helper
* improve governor helper
* improve governor helper
* refactor governor tests
* refactor testing
* fix testing (still TODO)
* fix tests
* fix tests
* fix spelling
* use different instances of GovernorHelper
* add vote with params support
* coverage
* simplify ERC165 helper
* remove unused proposal argument
* refactor setProposal
* lint
* refactor setProposal return values
* add a data default value
* improve proposal reconstruction and storage in helper
* proposal object refactoring
* lint
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
e192fac276
Simplify UUPSUpgradeable along the lines of ERC1822 ( #3021 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
6c1a634053
Add Governor contracts ( #2672 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
Hadrien Croubois
1488d4f678
Improve ECDSA tests and docs ( #2619 )
4 years ago
Francisco Giordano
508a879ef0
Remove merkleTree.js in favor of merkletreejs dependency ( #2578 )
4 years ago
Hadrien Croubois
f7c8252611
Remove GSNv1 contracts ( #2521 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
Nicolás Venturo
ecc66719bd
Add ERC20 Permit (EIP-2612) ( #2237 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
4 years ago
Francisco Giordano
f06738828b
Migrate to Hardhat ( #2397 )
4 years ago
Francisco Giordano
ace35fdeda
Update all dependencies transitively ( #2363 )
4 years ago
tincho
aaa5ef81cf
Fix typos ( #2343 )
4 years ago
dependabot-preview[bot]
b362e886ec
Bump ethereumjs-util from 6.2.0 to 7.0.0 ( #2222 )
...
* Bump ethereumjs-util from 6.2.0 to 7.0.0
Bumps [ethereumjs-util](https://github.com/ethereumjs/ethereumjs-util ) from 6.2.0 to 7.0.0.
- [Release notes](https://github.com/ethereumjs/ethereumjs-util/releases )
- [Changelog](https://github.com/ethereumjs/ethereumjs-util/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ethereumjs/ethereumjs-util/compare/v6.2.0...v7.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* update use of ethereumjs-util
* fix use of keccak hash function
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
5 years ago
Nicolás Venturo
5f92adc2e7
Migrate from truffle to test-environment ( #2007 )
...
* Sketch
* Migrate all tests to test-env
* Finish migration to test-env
* Add config
* Work on GSN tests
* Migrate to newer test-env version and loader syntax
* Add GSN setup
* Finish test-env migration
* Setup coverage using test-env
* Migrate to npm package
* Fix package.json
* Add compile step to CI
* Add comment on coverage setup
* Remove dependency on @truffle/contract
* Fix package-lock merge
* Fix linter errors
* Upgrade test-environment, depend locally on ganche-coverage
* Improve coverage script
* Improve sign.js API
* Move accounts destructuring to describe block
* Switch to prebuilt ethereumjs-vm package
* Upgrade test-enviroment version
* use workspace in circleci config
* remove unnecessary npx
5 years ago
Roman Storm
f358a03043
20x performance for merkle tree lib ( #1787 )
...
* 20x performance for merkle tree lib
* add semicolon
* Update test/helpers/merkleTree.js
Co-Authored-By: Nicolás Venturo <nicolas.venturo@gmail.com>
6 years ago
Thomas Bocek
79dd498b16
Signature Malleability: ( #1622 )
...
* Transaction Malleability:
If you allow for both values 0/1 and 27/28, you allow two different
signatures both resulting in a same valid recovery. (r,s,0/1) and
(r,s,27/28) would both be valid, recover the same public key and sign
the same data. Furthermore, given (r,s,0/1), (r,s,27/28) can be
constructed by anyone.
* Transaction Malleability:
EIP-2 still allows signature malleabality for ecrecover(), remove this
possibility and force the signature to be unique.
* Added a reference to appendix F to the yellow paper and improved
comment.
* better test description for testing the version 0, which returns
a zero address
* Check that the conversion from 0/1 to 27/28 only happens if its 0/1
* improved formatting
* Refactor ECDSA code a bit.
* Refactor ECDSA tests a bit.
* Add changelog entry.
* Add high-s check test.
6 years ago
Nicolás Venturo
3e82db2f6f
Migration to truffle 5 (and web3 1.0 (and BN)) ( #1601 )
...
* Now compiling using truffle 5.
* Migrated some test files, missing BN scientific notation usage.
* Now using BN time values.
* Migrate ERC20 tests.
* Migrate all ERC20 tests.
* Migrate utils, payment and ownership tests.
* All tests save ERC721 migrated.
* Migrated ERC721 tests.
* Fix lint errors.
* Delete old test helpers.
* Fix remaining crowdsale tests.
* Fix signature bouncer tests.
* Update how constants is used.
* Compile script pre-removes the build dir.
* Fix SafeMath tests.
* Revert "Compile script pre-removes the build dir."
This reverts commit 247e745113
.
* Fix linter errors.
* Upgrade openzeppelin-test-helpers dependency.
* Update openzeppelin-test-helpers dependency.
* Define math constants globally.
* Remove unnecessary ether unit.
* Roll back reduced ether amounts in tests.
* Remove unnecessary toNumber conversions.
* Delete compile script.
* Fixed failing test.
6 years ago
Aniket
350aae09d2
BigNumber comparison improved ( #1581 )
...
* signing prefix added
* Minor improvement
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4
.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* added examples
* fixes #706
* linting
* fixes #204
* file fixing
* deep bignumber comparison removed
* Update SafeERC20Helper.sol
* Update IERC20.sol
* Update SafeERC20.sol
* Update package-lock.json
* Revert "deep bignumber comparison removed"
This reverts commit 230b27214f
.
6 years ago
Francisco Giordano
d17ae0b806
Signed SafeMath ( #1559 )
...
* signed safe math
* fix lint errors
* refactor overflow checks and add descriptions
* remove incorrect description
* add test for reversed arguments in multiplication test
* fix power operator
* improve multiplication test descriptions
* Update SafeMath.test.js
* add feature to changelog
6 years ago
Aniket
70fd243e3b
Test setup helper added ( #1482 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4
.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1205
* minor change
* suggested changes
* reviewed changes
* final update
6 years ago
Nicolás Venturo
b7d56d5471
Added explicity pify dep, deprecating web3.eth. ( #1532 )
...
* Added explicity pify dep, deprecating web3.eth.
* Dropped promisify in favor of pify.
6 years ago