address review comments from AniketEngg

pull/1671/head
Joseph Izang 3 years ago
parent e028786d35
commit 010ce173c4
  1. 1
      apps/remix-ide-e2e/src/tests/gist.test.ts
  2. 6
      apps/remix-ide/src/app/components/vertical-icons.js
  3. 2
      libs/remix-ui/vertical-icons-panel/README.md
  4. 1
      libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx
  5. 1
      libs/remix-ui/vertical-icons-panel/src/lib/vertical-icons-context-menu.tsx
  6. 3
      libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel.d.ts

@ -72,7 +72,6 @@ module.exports = {
browser.clickLaunchIcon('home')
.waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000)
.clickLaunchIcon('filePanel')
// .scrollAndClick('*[data-id="landingPageImportFromGistButton"]')
.click('div[title="home"]')
.waitForElementVisible('button[data-id="landingPageImportFromGistButton"]')
.pause(1000)

@ -9,10 +9,8 @@ var yo = require('yo-yo')
var csjs = require('csjs-inject')
var helper = require('../../lib/helper')
const globalRegistry = require('../../global/registry')
// const contextMenu = require('../ui/contextMenu')
const { Plugin } = require('@remixproject/engine')
const EventEmitter = require('events')
// let VERTICALMENU_HANDLE
const profile = {
name: 'menuicons',
@ -123,7 +121,7 @@ export class VerticalIcons extends Plugin {
* Remove an icon from the map
* @param {ModuleProfile} profile The profile of the module
*/
removeIcon ({ kind, name }) {
removeIcon ({ name }) {
if (this.targetProfileForChange[name]) delete this.targetProfileForChange[name]
this.renderComponent()
}
@ -143,7 +141,7 @@ export class VerticalIcons extends Plugin {
* @param {string} name Name of profile of the module to activate
*/
toggle (name) {
// // TODO: Only keep `this.emit` (issue#2210)
// TODO: Only keep `this.emit` (issue#2210)
this.emit('toggleContent', name)
this.events.emit('toggleContent', name)
}

@ -1,6 +1,6 @@
# remix-ui-vertical-icons-panel
This library was generated with [Nx](https://nx.dev).
React library for RemixIde vertical icons Panel
## Running unit tests

@ -5,7 +5,6 @@ import VerticalIconsContextMenu from '../vertical-icons-context-menu'
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import React, { Fragment, SyntheticEvent, useRef, useState } from 'react'
import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel'
// import helper from 'apps/remix-ide/src/lib/helper'
interface IconProps {
verticalIconPlugin: VerticalIcons

@ -6,7 +6,6 @@ import React, { Fragment, useEffect, useRef } from 'react'
import { VerticalIcons } from '../../types/vertical-icons-panel'
export interface VerticalIconsContextMenuProps extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement> {
// actions: action[]
pageX: number
pageY: number
profileName: string

@ -43,7 +43,6 @@ interface targetProfileIcons {
profile: PassedProfile
}
export class VerticalIcons extends Plugin<any, any> {
// constructor(appManager: RemixAppManager)
events: EventEmitter
appManager: RemixAppManager
htmlElement: HTMLDivElement
@ -83,7 +82,7 @@ export class VerticalIcons extends Plugin<any, any> {
* Remove an icon from the map
* @param {ModuleProfile} profile The profile of the module
*/
removeIcon({ kind, name }: any): void
removeIcon({ name }: any): void
/**
* Remove active for the current activated icons
*/

Loading…
Cancel
Save