Merge pull request #791 from ethereum/yann300-patch-8

Fix encoding fallback function

remix-lib/src/execution/txHelper.js

@@ -21,6 +21,7 @@ module.exports = {
   },
 
   encodeFunctionId: function (funABI) {
+    if (funABI.type === 'fallback') return '0x'
     var abi = new ethers.Interface([funABI])
     abi = abi.functions[funABI.name]
     return abi.sighash

remix-lib/test/txFormat.js

@@ -1,6 +1,7 @@
 'use strict'
 var tape = require('tape')
 var txFormat = require('../src/execution/txFormat')
+var txHelper = require('../src/execution/txHelper')
 var compiler = require('solc')
 var compilerInput = require('../src/helpers/compilerHelper').compilerInput
 var executionContext = require('../src/execution/execution-context')
@@ -149,6 +150,17 @@ function encodeFunctionCallTest (st) {
 
 /* *********************************************************** */
 
+tape('test fallback function', function (t) {
+  t.test('(fallback)', function (st) {
+    st.plan(2)
+    var output = compiler.compileStandardWrapper(compilerInput(fallbackFunction))
+    output = JSON.parse(output)
+    var contract = output.contracts['test.sol']['fallbackFunctionContract']
+    st.equal(txHelper.encodeFunctionId(contract.abi[0]), '0x805da4ad')
+    st.equal(txHelper.encodeFunctionId(contract.abi[1]), '0x')
+  })
+})
+
 var uintContract = `contract uintContractTest {
     uint _tp;
     address _ap;
@@ -186,3 +198,13 @@ contract testContractLinkLibrary {
         
  }
  }`
+
+var fallbackFunction = `pragma solidity ^0.4.4;
+
+contract fallbackFunctionContract { 
+    function get (uint _p, string _o) {
+        
+    }
+    
+    function () {}
+ }`