Merge pull request #587 from ethereum/highlightingTab

Move highlighting tab logic to settings tab

src/app.js

@@ -6,8 +6,6 @@ var $ = require('jquery')
 var base64 = require('js-base64').Base64
 var swarmgw = require('swarmgw')
 var csjs = require('csjs-inject')
-var styleGuide = require('./app/style-guide')
-var styles = styleGuide()
 
 var QueryParams = require('./app/query-params')
 var queryParams = new QueryParams()
@@ -31,27 +29,10 @@ var tabbedMenu = require('./app/tabbed-menu')
 var examples = require('./app/example-contracts')
 
 var contractTab = require('./app/contract-tab.js')
-var settingsTab = require('./app/settings-tab.js')
+var SettingsTab = require('./app/settings-tab.js')
 var analysisTab = require('./app/analysis-tab.js')
 var debuggerTab = require('./app/debugger-tab.js')
 var filesTab = require('./app/files-tab.js')
-/* ----------------------------------------------
-        TABS - Righthand pannel
----------------------------------------------- */
-var contractView = contractTab()
-document.querySelector('#optionViews').appendChild(contractView)
-
-var settingsView = settingsTab()
-document.querySelector('#optionViews').appendChild(settingsView)
-
-var analysisView = analysisTab()
-document.querySelector('#optionViews').appendChild(analysisView)
-
-var debuggerView = debuggerTab()
-document.querySelector('#optionViews').appendChild(debuggerView)
-
-var filesView = filesTab()
-document.querySelector('#optionViews').appendChild(filesView)
 
 // The event listener needs to be registered as early as possible, because the
 // parent will send the message upon the "load" event.
@@ -63,18 +44,32 @@ window.addEventListener('message', function (ev) {
     loadFilesCallback(ev.data[1])
   }
 }, false)
-
 var run = function () {
   var self = this
   this.event = new EventManager()
   var fileStorage = new Storage('sol:')
   var files = new Files(fileStorage)
   var config = new Config(fileStorage)
-
-  var executionContext = new ExecutionContext()
   var compiler = new Compiler(handleImportCall)
   var offsetToLineColumnConverter = new OffsetToLineColumnConverter(compiler.event)
+  /* ----------------------------------------------
+          TABS - Righthand pannel
+  ------------------------------------------------ */
+  var contractView = contractTab()
+  document.querySelector('#optionViews').appendChild(contractView)
+
+  var settingsView = new SettingsTab('#optionViews', {}, {compiler: compiler.event}, {})
 
+  var analysisView = analysisTab()
+  document.querySelector('#optionViews').appendChild(analysisView)
+
+  var debuggerView = debuggerTab()
+  document.querySelector('#optionViews').appendChild(debuggerView)
+
+  var filesView = filesTab()
+  document.querySelector('#optionViews').appendChild(filesView)
+
+  var executionContext = new ExecutionContext()
   // return all the files, except the temporary/readonly ones
   function packageFiles () {
     var ret = {}
@@ -812,25 +807,6 @@ var run = function () {
     config.set('autoCompile', autoCompile)
   })
 
-  var cssCompilationWarning = csjs`
-    .compilationWarning extends ${styles.warningTextBox} {
-      margin-top: 1em;
-      margin-left: 0.5em;
-    }
-  `
-  var warnMsg = ' Last compilation took {X}ms. We suggest to turn off autocompilation.'
-  compiler.event.register('compilationDuration', (speed) => {
-    $('#warnCompilationSlow').html('')
-    $('#warnCompilationSlow').hide()
-    $('#header #menu .settingsView').css('color', '')
-    if (speed > 1000) {
-      document.querySelector('#warnCompilationSlow').className = cssCompilationWarning.compilationWarning
-      $('#warnCompilationSlow').show()
-      $('#warnCompilationSlow').html(warnMsg.replace('{X}', speed))
-      $('#header #menu .settingsView').css('color', '#FF8B8B')
-    }
-  })
-
   function runCompiler () {
     if (transactionDebugger.isActive) return
 

src/app/settings-tab.js

@@ -34,12 +34,31 @@ var css = csjs`
   .checkboxText {
     margin-left: 3px;
   }
+  .compilationWarning extends ${styles.warningTextBox} {
+    margin-top: 1em;
+    margin-left: 0.5em;
+  }
 }
 `
-module.exports = settingsTab
+module.exports = SettingsTab
+
+function SettingsTab (container, appAPI, appEvents, opts) {
+  if (typeof container === 'string') container = document.querySelector(container)
+  if (!container) throw new Error('no container given')
+
+  var warnCompilationSlow = yo`<div id="warnCompilationSlow"></div>`
+
+  appEvents.compiler.register('compilationDuration', function tabHighlighting (speed) {
+    var settingsView = document.querySelector('#header #menu .settingsView')
+    if (speed > 1000) {
+      warnCompilationSlow.className = css.compilationWarning
+      warnCompilationSlow.innerHTML = `Last compilation took ${speed}ms. We suggest to turn off autocompilation.`
+      warnCompilationSlow.style.visibility = 'visible'
+      settingsView.style.color = '#FF8B8B'
+    }
+  })
 
-function settingsTab () {
-  return yo`
+  var el = yo`
     <div class="${css.settingsTabView} "id="settingsView">
       <div class="${css.info}">
         <div>Your current Solidity version is</div>
@@ -64,7 +83,8 @@ function settingsTab () {
       <div class="${css.crow}">
         <div class="${css.button} "id="compile" title="Compile source code">Compile</div>
       </div>
-      <div id="warnCompilationSlow" class="${css.compilationWarning}"></div>
+      ${warnCompilationSlow}
     </div>
   `
+  container.appendChild(el)
 }