filter slither warnings

libs/remix-ui/static-analyser/src/lib/remix-ui-static-analyser.tsx

@@ -64,7 +64,7 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
   const [autoRun, setAutoRun] = useState(true)
   const [slitherEnabled, setSlitherEnabled] = useState(false)
   const [showSlither, setShowSlither] = useState(false)
-  let [showLibsWarning, setShowLibsWarning] = useState(false)
+  let [showLibsWarning, setShowLibsWarning] = useState(false) // eslint-disable-line prefer-const
   const [categoryIndex, setCategoryIndex] = useState(groupedModuleIndex(groupedModules))
   const [warningState, setWarningState] = useState({})
 
@@ -185,7 +185,6 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
   const run = async (lastCompilationResult, lastCompilationSource, currentFile) => {
     if (state.data !== null) {
       if (lastCompilationResult && (categoryIndex.length > 0 || slitherEnabled)) {
-        let warningCount = 0
         const warningMessage = []
         const warningErrors = []
 
@@ -208,6 +207,7 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
             let row = 0
             let fileName = currentFile
             let isLibrary = false
+
             if (item.location) {
               const split = item.location.split(':')
               const file = split[2]
@@ -251,11 +251,12 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
         }
         // Slither Analysis
         if (slitherEnabled) {
-            props.analysisModule.call('solidity', 'getCompilerState').then((compilerState) => {
+          try {
+            const compilerState = await props.analysisModule.call('solidity', 'getCompilerState')
             const { currentVersion, optimize, evmVersion } = compilerState
-              props.analysisModule.call('terminal', 'log', { type: 'info', value: '[Slither Analysis]: Running...' })
+            await props.analysisModule.call('terminal', 'log', { type: 'info', value: '[Slither Analysis]: Running...' })
             _paq.push(['trackEvent', 'solidityStaticAnalyzer', 'analyzeWithSlither'])
-              props.analysisModule.call('slither', 'analyse', state.file, { currentVersion, optimize, evmVersion }).then(async (result) => {
+            const result = await props.analysisModule.call('slither', 'analyse', state.file, { currentVersion, optimize, evmVersion })
             if (result.status) {
               props.analysisModule.call('terminal', 'log', { type: 'info', value: `[Slither Analysis]: Analysis Completed!! ${result.count} warnings found.` })
               const report = result.data
@@ -265,6 +266,7 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
                 let column = 0
                 let row = 0
                 let fileName = currentFile
+                let isLibrary = false
 
                 if (item.sourceMap && item.sourceMap.length) {
                   let path = item.sourceMap[0].source_mapping.filename_relative
@@ -290,14 +292,17 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
                     fileName = Object.keys(lastCompilationResult.sources)[fileIndex]
                   }
                 }
-
-                    warningCount++
+                if(fileName !== currentFile) {
+                  const {file, provider} = await props.analysisModule.call('fileManager', 'getPathFromUrl', fileName)
+                  if (file.startsWith('.deps') || (provider.type === 'localhost' && file.startsWith('localhost/node_modules'))) isLibrary = true
+                } 
                 const msg = message(item.title, item.description, item.more, fileName, locationString)
                 const options = {
                   type: 'warning',
                   useSpan: true,
                   errFile: fileName,
                   fileName,
+                  isLibrary,
                   errLine: row,
                   errCol: column,
                   item: { warning: item.description },
@@ -310,16 +315,12 @@ export const RemixUiStaticAnalyser = (props: RemixUiStaticAnalyserProps) => {
                 warningMessage.push({ msg, options, hasWarning: true, warningModuleName: 'Slither Analysis' })
               }
               showWarnings(warningMessage, 'warningModuleName')
-                  props.event.trigger('staticAnaysisWarning', [warningCount])
             }
-              }).catch(() => {
+          } catch(error) {
             props.analysisModule.call('terminal', 'log', { type: 'error', value: '[Slither Analysis]: Error occured! See remixd console for details.' })
             showWarnings(warningMessage, 'warningModuleName')
-              })
-            })
-          } else {
-            showWarnings(warningMessage, 'warningModuleName')
           }
+        } else showWarnings(warningMessage, 'warningModuleName')
       } else {
         if (categoryIndex.length) {
           warningContainer.current.innerText = 'No compiled AST available'