fix url test

apps/remix-ide-e2e/src/tests/url.test.ts

@@ -224,8 +224,10 @@ module.exports = {
 
       .clickLaunchIcon('solidity')
       .click('*[data-id="scConfigExpander"]')
-      .waitForElementVisible('#versionSelector option[data-id="selected"]')
-      .assert.containsText('#versionSelector option[data-id="selected"]', '0.8.16+commit.07a7930e')
+      .waitForElementVisible({
+        selector: "//*[@data-id='selectedVersion' and contains(.,'0.8.16+commit.07a7930e')]",
+        locateStrategy: 'xpath'
+      })
       .assert.containsText('#evmVersionSelector option[data-id="selected"]', 'istanbul')
       .assert.containsText('#compilierLanguageSelector option[data-id="selected"]', 'Yul')
       .verify.elementPresent('#optimize:checked')
@@ -235,14 +237,18 @@ module.exports = {
       .refreshPage()
 
       .clickLaunchIcon('solidity')
-      .waitForElementVisible('#versionSelector option[data-id="selected"]')
-      .assert.containsText('#versionSelector option[data-id="selected"]', '0.8.7+commit.e28d00a7')
+      .waitForElementVisible({
+        selector: "//*[@data-id='selectedVersion' and contains(.,'0.8.7+commit.e28d00a7')]",
+        locateStrategy: 'xpath'
+      })
       .url('http://127.0.0.1:8080/#version=0.8.15+commit.e14f2714')
       .refreshPage()
       .pause(3000)
       .clickLaunchIcon('solidity')
-      .waitForElementVisible('#versionSelector option[data-id="selected"]')
-      .assert.containsText('#versionSelector option[data-id="selected"]', '0.8.15+commit.e14f2714')
+      .waitForElementVisible({
+        selector: "//*[@data-id='selectedVersion' and contains(.,'0.8.15+commit.e14f2714')]",
+        locateStrategy: 'xpath'
+      })
   },
 
   'Should load using compiler from link passed in remix URL #group3': function (browser: NightwatchBrowser) {
@@ -253,7 +259,10 @@ module.exports = {
       .clickLaunchIcon('solidity')
 
       .click('*[data-id="scConfigExpander"]')
-      .assert.containsText('#versionSelector option[data-id="selected"]', 'custom')
+      .waitForElementVisible({
+        selector: "//*[@data-id='selectedVersion' and contains(.,'custom')]",
+        locateStrategy: 'xpath'
+      })
       // default values
       .assert.containsText('#evmVersionSelector option[data-id="selected"]', 'default')
       .verify.elementPresent('#optimize')

libs/remix-ui/solidity-compiler/src/lib/components/compiler-dropdown.tsx

@@ -15,7 +15,7 @@ interface compilerDropdownProps {
   defaultVersion: string,
   allversions: compilerVersion[],
   handleLoadVersion: (url: string) => void,
-  _shouldBeAdded: (version: string) => {},
+  _shouldBeAdded: (version: string) => boolean,
   onlyDownloaded: boolean
 }
 
@@ -28,12 +28,12 @@ export const CompilerDropdown = (props: compilerDropdownProps) => {
         <div style={{ flexGrow: 1, overflow: 'hidden', display:'flex', justifyContent:'left' }}>
           <div className="text-truncate">
             {customVersions.map((url, i) => {
-            if (selectedVersion === url) return (<span key={i}>custom</span>)
+              if (selectedVersion === url) return (<span data-id="selectedVersion" key={i}>custom</span>)
             })}
             {allversions.map((build, i) => {
 
               if ((selectedVersion || defaultVersion) === build.path) {
-              return (<span key={i}>{build.longVersion}</span>)
+                return (<span data-id="selectedVersion" key={i}>{build.longVersion}</span>)
               }
             })}
           </div>

libs/remix-ui/solidity-compiler/src/lib/solidity-compiler.tsx

@@ -166,7 +166,7 @@ export const SolidityCompiler = (props: SolidityCompilerProps) => {
       prerelease: ''
     }
     const binVersions = data.binList
-    let selectorList = binVersions
+    const selectorList = binVersions
     
     const wasmVersions = data.wasmList
     selectorList.forEach((compiler, index) => {