try encoding params in any case so we throw beforehand if something went wrong

6 years ago · 20e1a6051e
parent 88882b7634
commit 20e1a6051e
1 changed files with 6 additions and 8 deletions
--- a/remix-lib/src/execution/txFormat.js
+++ b/remix-lib/src/execution/txFormat.js
@ -186,14 +186,12 @@ module.exports = {
        callback('Error encoding arguments: ' + e)
        return
      }
-      if (!isConstructor || funArgs.length > 0) {
-        try {
-          data = helper.encodeParams(funAbi, funArgs)
-          dataHex = data.toString('hex')
-        } catch (e) {
-          callback('Error encoding arguments: ' + e)
-          return
-        }
+      try {
+        data = helper.encodeParams(funAbi, funArgs)
+        dataHex = data.toString('hex')
+      } catch (e) {
+        callback('Error encoding arguments: ' + e)
+        return
      }
      if (data.slice(0, 9) === 'undefined') {
        dataHex = data.slice(9)