Merge branch 'master' into githubmodal

pull/2364/head
bunsenstraat 3 years ago committed by GitHub
commit 244c57025d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      apps/remix-ide/src/app/files/fileManager.ts
  2. 14
      apps/remix-ide/src/app/panels/tab-proxy.js

@ -600,7 +600,7 @@ class FileManager extends Plugin {
// TODO: Only keep `this.emit` (issue#2210) // TODO: Only keep `this.emit` (issue#2210)
this.emit('fileRemoved', path) this.emit('fileRemoved', path)
this.events.emit('fileRemoved', path) this.events.emit('fileRemoved', path)
this.openFile() this.openFile(this._deps.config.get('currentFile'))
} }
async unselectCurrentFile() { async unselectCurrentFile() {

@ -41,7 +41,13 @@ export class TabProxy extends Plugin {
if (this.fileManager.mode === 'browser') { if (this.fileManager.mode === 'browser') {
name = name.startsWith(workspace + '/') ? name : workspace + '/' + name name = name.startsWith(workspace + '/') ? name : workspace + '/' + name
this.removeTab(name) // If deleted file is not current file and not an active tab in editor,
// ensure current file is active in the editor
if (this.fileManager.currentFile() && name !== this.fileManager.currentFile()) {
const currentFile = this.fileManager.currentFile()
const currentFileTabPath = currentFile.startsWith(workspace + '/') ? currentFile : workspace + '/' + currentFile
this.removeTab(name, { name: currentFileTabPath })
} else this.removeTab(name)
} else { } else {
name = name.startsWith(this.fileManager.mode + '/') ? name : this.fileManager.mode + '/' + name name = name.startsWith(this.fileManager.mode + '/') ? name : this.fileManager.mode + '/' + name
this.removeTab(name) this.removeTab(name)
@ -261,11 +267,11 @@ export class TabProxy extends Plugin {
this._handlers[name] = { switchTo, close } this._handlers[name] = { switchTo, close }
} }
removeTab (name) { removeTab (name, currentFileTab) {
delete this._handlers[name] delete this._handlers[name]
let previous = null let previous = currentFileTab
this.loadedTabs = this.loadedTabs.filter((tab, index) => { this.loadedTabs = this.loadedTabs.filter((tab, index) => {
if (tab.name === name) previous = this.loadedTabs[index - 1] if (!previous && tab.name === name) previous = this.loadedTabs[index - 1]
return tab.name !== name return tab.name !== name
}) })
this.renderComponent() this.renderComponent()

Loading…
Cancel
Save