Merge pull request #2577 from ethereum/mainnet-fix

function call fixed
pull/1/head
yann300 5 years ago committed by GitHub
commit 43b756abf5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 14
      src/app/ui/sendTxCallbacks.js
  2. 4
      src/app/ui/universal-dapp-ui.js

@ -7,18 +7,18 @@ const typeConversion = remixLib.execution.typeConversion
const Web3 = require('web3') const Web3 = require('web3')
module.exports = { module.exports = {
getCallBacksWithContext: (udapp, executionContext) => { getCallBacksWithContext: (udappUI, executionContext) => {
let callbacks = {} let callbacks = {}
callbacks.confirmationCb = confirmationCb callbacks.confirmationCb = confirmationCb
callbacks.continueCb = continueCb callbacks.continueCb = continueCb
callbacks.promptCb = promptCb callbacks.promptCb = promptCb
callbacks.udapp = udapp callbacks.udappUI = udappUI
callbacks.executionContext = executionContext callbacks.executionContext = executionContext
return callbacks return callbacks
} }
} }
const continueCb = (error, continueTxExecution, cancelCb) => { const continueCb = function (error, continueTxExecution, cancelCb) {
if (error) { if (error) {
const msg = typeof error !== 'string' ? error.message : error const msg = typeof error !== 'string' ? error.message : error
modalDialog( modalDialog(
@ -41,17 +41,17 @@ const continueCb = (error, continueTxExecution, cancelCb) => {
} }
} }
const promptCb = (okCb, cancelCb) => { const promptCb = function (okCb, cancelCb) {
modalCustom.promptPassphrase('Passphrase requested', 'Personal mode is enabled. Please provide passphrase of account', '', okCb, cancelCb) modalCustom.promptPassphrase('Passphrase requested', 'Personal mode is enabled. Please provide passphrase of account', '', okCb, cancelCb)
} }
const confirmationCb = (network, tx, gasEstimation, continueTxExecution, cancelCb) => { const confirmationCb = function (network, tx, gasEstimation, continueTxExecution, cancelCb) {
let self = this let self = this
if (network.name !== 'Main') { if (network.name !== 'Main') {
return continueTxExecution(null) return continueTxExecution(null)
} }
var amount = Web3.utils.fromWei(typeConversion.toInt(tx.value), 'ether') var amount = Web3.utils.fromWei(typeConversion.toInt(tx.value), 'ether')
var content = confirmDialog(tx, amount, gasEstimation, self.udapp, var content = confirmDialog(tx, amount, gasEstimation, self.udappUI,
(gasPrice, cb) => { (gasPrice, cb) => {
let txFeeText, priceStatus let txFeeText, priceStatus
// TODO: this try catch feels like an anti pattern, can/should be // TODO: this try catch feels like an anti pattern, can/should be
@ -86,7 +86,7 @@ const confirmationCb = (network, tx, gasEstimation, continueTxExecution, cancelC
content, content,
{ label: 'Confirm', { label: 'Confirm',
fn: () => { fn: () => {
self.udapp.config.setUnpersistedProperty( self.udappUI.udapp.config.setUnpersistedProperty(
'doNotShowTransactionConfirmationAgain', 'doNotShowTransactionConfirmationAgain',
content.querySelector('input#confirmsetting').checked content.querySelector('input#confirmsetting').checked
) )

@ -253,7 +253,7 @@ UniversalDAppUI.prototype.runTransaction = function (lookupOnly, args, valArr, i
self.logCallback(`${logMsg}`) self.logCallback(`${logMsg}`)
} }
if (args.funABI.type === 'fallback') data.dataHex = value if (args.funABI.type === 'fallback') data.dataHex = value
self.udapp.callFunction(args.address, data, args.funABI, callbacksInContext.confirmationCb, callbacksInContext.continueCb, callbacksInContext.promptCb, (error, txResult) => { self.udapp.callFunction(args.address, data, args.funABI, callbacksInContext.confirmationCb.bind(callbacksInContext), callbacksInContext.continueCb.bind(callbacksInContext), callbacksInContext.promptCb.bind(callbacksInContext), (error, txResult) => {
if (!error) { if (!error) {
var isVM = self.executionContext.isVM() var isVM = self.executionContext.isVM()
if (isVM) { if (isVM) {
@ -278,7 +278,7 @@ UniversalDAppUI.prototype.runTransaction = function (lookupOnly, args, valArr, i
self.logCallback(msg) self.logCallback(msg)
}, (data, runTxCallback) => { }, (data, runTxCallback) => {
// called for libraries deployment // called for libraries deployment
self.udapp.runTx(data, callbacksInContext.confirmationCb, runTxCallback) self.udapp.runTx(data, callbacksInContext.confirmationCb.bind(callbacksInContext), runTxCallback)
}) })
} }

Loading…
Cancel
Save