Merge pull request #2908 from ethereum/cleanCompilerAPI

remove uneeded "compilerUrl" param
pull/5370/head
yann300 4 years ago committed by GitHub
commit 4de8f88a97
  1. 4
      src/app/tabs/compile-tab.js
  2. 3
      test-browser/tests/compiler_api.test.js

@ -218,7 +218,7 @@ class CompileTab extends ViewPlugin {
* The module UI will *not* be updated, the compilation result is returned * The module UI will *not* be updated, the compilation result is returned
* This function is used by remix-plugin compiler API. * This function is used by remix-plugin compiler API.
* @param {object} map of source files. * @param {object} map of source files.
* @param {object} settings {evmVersion, optimize, compilerUrl, version, language} * @param {object} settings {evmVersion, optimize, version, language}
*/ */
async compileWithParameters (compilationTargets, settings) { async compileWithParameters (compilationTargets, settings) {
return await compile(compilationTargets, settings) return await compile(compilationTargets, settings)
@ -241,7 +241,7 @@ class CompileTab extends ViewPlugin {
/** /**
* set the compiler configuration * set the compiler configuration
* This function is used by remix-plugin compiler API. * This function is used by remix-plugin compiler API.
* @param {object} settings {evmVersion, optimize, compilerUrl, version, language} * @param {object} settings {evmVersion, optimize, version, language}
*/ */
setCompilerConfig (settings) { setCompilerConfig (settings) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {

@ -76,8 +76,7 @@ const jsCompile = `(async () => {
optimize: false, optimize: false,
evmVersion: null, evmVersion: null,
language: 'Solidity', language: 'Solidity',
version: '0.6.8+commit.0bbfe453', version: '0.6.8+commit.0bbfe453'
compilerUrl: 'https://solc-bin.ethereum.org/bin/soljson-v0.6.8+commit.0bbfe453.js'
} }
const result = await remix.call('solidity', 'compileWithParameters', contract, params) const result = await remix.call('solidity', 'compileWithParameters', contract, params)
console.log('result ', result) console.log('result ', result)

Loading…
Cancel
Save