address review comments from @ioedeveloper

pull/1671/head
Joseph Izang 3 years ago
parent 3a51c5a719
commit 5a99d1a72f
  1. 35
      .eslintrc.json
  2. 3
      libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx
  3. 12
      libs/remix-ui/vertical-icons-panel/src/lib/components/OtherIcons.tsx
  4. 7
      libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx

@ -1,35 +0,0 @@
{
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nrwl/nx"],
"overrides": [
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {
"@nrwl/nx/enforce-module-boundaries": [
"error",
{
"enforceBuildableLibDependency": true,
"allow": [],
"depConstraints": [
{
"sourceTag": "*",
"onlyDependOnLibsWithTags": ["*"]
}
]
}
]
}
},
{
"files": ["*.ts", "*.tsx"],
"extends": ["plugin:@nrwl/nx/typescript"],
"rules": {}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nrwl/nx/javascript"],
"rules": {}
}
]
}

@ -3,8 +3,9 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars // eslint-disable-next-line @typescript-eslint/no-unused-vars
import VerticalIconsContextMenu from '../vertical-icons-context-menu' import VerticalIconsContextMenu from '../vertical-icons-context-menu'
// eslint-disable-next-line @typescript-eslint/no-unused-vars // eslint-disable-next-line @typescript-eslint/no-unused-vars
import React, { Fragment, SyntheticEvent, useRef, useState } from 'react' import React, { Fragment, SyntheticEvent, useEffect, useRef, useState } from 'react'
import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel' import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel'
// import * as helper from '../../../../../../apps/remix-ide/src/lib/helper'
interface IconProps { interface IconProps {
verticalIconPlugin: VerticalIcons verticalIconPlugin: VerticalIcons

@ -1,6 +1,5 @@
/* eslint-disable no-use-before-define */ /* eslint-disable no-use-before-define */
/* eslint-disable @typescript-eslint/no-unused-vars */ /* eslint-disable @typescript-eslint/no-unused-vars */
<<<<<<< HEAD
import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel' import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel'
import React from 'react' import React from 'react'
import Icon from './Icon' import Icon from './Icon'
@ -49,17 +48,6 @@ function OtherIcons ({ verticalIconsPlugin, itemContextAction, addActive, remove
/> />
))} ))}
</div> </div>
=======
import React, { ReactNode } from 'react'
interface OtherIconsProps {
children: ReactNode
}
function OtherIcons ({ children }: OtherIconsProps) {
return (
<div id="otherIcons">{ children }</div>
>>>>>>> b6322066e (update components and setttings)
) )
} }

@ -1,11 +1,9 @@
/* eslint-disable no-use-before-define */ /* eslint-disable no-use-before-define */
/* eslint-disable @typescript-eslint/no-unused-vars */ /* eslint-disable @typescript-eslint/no-unused-vars */
import React, { import {
Fragment, Fragment,
useEffect, useEffect,
useReducer, useRef
useRef,
useState
} from 'react' } from 'react'
import './remix-ui-vertical-icons-panel.css' import './remix-ui-vertical-icons-panel.css'
@ -25,7 +23,6 @@ export function RemixUiVerticalIconsPanel ({
}: RemixUiVerticalIconsPanelProps) { }: RemixUiVerticalIconsPanelProps) {
const scrollableRef = useRef<any>() const scrollableRef = useRef<any>()
const iconPanelRef = useRef<any>() const iconPanelRef = useRef<any>()
// const [first] = useState(localStorage.getItem('firstTime'))
function onThemeChanged (themeType: any) { function onThemeChanged (themeType: any) {
const invert = themeType === 'dark' ? 1 : 0 const invert = themeType === 'dark' ? 1 : 0

Loading…
Cancel
Save