Merge pull request #1915 from ethereum/dontConnect_Metamask_atLoad

don't init at pageload but when run tab loads

src/app.js

@@ -129,9 +129,6 @@ class App {
     self._components.config = new Config(fileStorage)
     registry.put({api: self._components.config, name: 'config'})
 
-    executionContext.init(self._components.config)
-    executionContext.listenOnLastBlock()
-
     self._components.gistHandler = new GistHandler()
 
     self._components.filesProviders = {}

src/app/tabs/run-tab.js

@@ -12,6 +12,8 @@ var ContractDropdownUI = require('./runTab/contractDropdown.js')
 var Recorder = require('./runTab/model/recorder.js')
 var RecorderUI = require('./runTab/recorder.js')
 
+const executionContext = require('../../execution-context')
+
 import { BaseApi } from 'remix-plugin'
 
 const profile = {
@@ -30,13 +32,15 @@ class RunTab extends BaseApi {
   constructor (udapp, udappUI, config, fileManager, editor, logCallback, filePanel, pluginManager, compilersArtefacts) {
     super(profile)
     this.event = new EventManager()
-
+    this.config = config
-    this.renderInstanceContainer()
+    this.udapp = udapp
-    this.renderSettings(udapp)
+    this.udappUI = udappUI
-    this.renderDropdown(udappUI, fileManager, pluginManager, compilersArtefacts, config, editor, udapp, filePanel, logCallback)
+    this.fileManager = fileManager
-    this.renderRecorder(udapp, udappUI, fileManager, config, logCallback)
+    this.editor = editor
-    this.renderRecorderCard()
+    this.logCallback = logCallback
-    this.renderContainer()
+    this.filePanel = filePanel
+    this.pluginManager = pluginManager
+    this.compilersArtefacts = compilersArtefacts
   }
 
   renderContainer () {
@@ -51,6 +55,7 @@ class RunTab extends BaseApi {
     </div>
     `
     this.container.appendChild(el)
+    return this.container
   }
 
   renderInstanceContainer () {
@@ -158,7 +163,16 @@ class RunTab extends BaseApi {
   }
 
   render () {
-    return this.container
+    executionContext.init(this.config)
+    executionContext.stopListenOnLastBlock()
+    executionContext.listenOnLastBlock()
+    this.udapp.resetEnvironment()
+    this.renderInstanceContainer()
+    this.renderSettings(this.udapp)
+    this.renderDropdown(this.udappUI, this.fileManager, this.pluginManager, this.compilersArtefacts, this.config, this.editor, this.udapp, this.filePanel, this.logCallback)
+    this.renderRecorder(this.udapp, this.udappUI, this.fileManager, this.config, this.logCallback)
+    this.renderRecorderCard()
+    return this.renderContainer()
   }
 
 }

src/universal-dapp.js

@@ -38,7 +38,6 @@ module.exports = class UniversalDApp extends UdappApi {
     }
     this.txRunner = new TxRunner({}, this._txRunnerAPI)
     this.accounts = {}
-    this.resetEnvironment()
     executionContext.event.register('contextChanged', this.resetEnvironment.bind(this))
   }