Run ci linting for udapp

libs/remix-ui/run-tab/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": ["plugin:@nrwl/nx/react", "../../../.eslintrc"],
+  "extends": ["plugin:@nrwl/nx/react", "../../../.eslintrc.json"],
   "ignorePatterns": ["!**/*"],
   "overrides": [
     {

libs/remix-ui/run-tab/src/lib/actions/index.ts

@@ -328,7 +328,6 @@ const loadContractFromAddress = (address, confirmCb, cb) => {
       try {
         abi = JSON.parse(plugin.editor.currentContent())
       } catch (e) {
-        // eslint-disable-next-line standard/no-callback-literal
         return cb('Failed to parse the current file as JSON ABI.')
       }
       _paq.push(['trackEvent', 'udapp', 'AtAddressLoadWithABI'])
@@ -654,11 +653,9 @@ const saveScenario = (promptCb, cb) => {
     const newFile = path + '/' + plugin.REACT_API.recorder.pathToScenario
     try {
       const newPath = await createNonClashingNameAsync(newFile, plugin.fileManager)
-      // eslint-disable-next-line standard/no-callback-literal
       if (!fileProvider.set(newPath, txJSON)) return cb('Failed to create file ' + newFile)
       plugin.fileManager.open(newFile)
     } catch (error) {
-      // eslint-disable-next-line standard/no-callback-literal
       if (error) return cb('Failed to create file. ' + newFile + ' ' + error)
     }
   })

libs/remix-ui/run-tab/src/lib/components/contractDropdownUI.tsx

@@ -183,7 +183,7 @@ export function ContractDropdownUI (props: ContractDropdownProps) {
     return (
       <span>
         It seems you are not using a checksumed address.
-        <br />A checksummed address is an address that contains uppercase letters, as specified in <a href="https://eips.ethereum.org/EIPS/eip-55" target="_blank">EIP-55</a>.
+        <br />A checksummed address is an address that contains uppercase letters, as specified in <a href="https://eips.ethereum.org/EIPS/eip-55" target="_blank" rel="noreferrer">EIP-55</a>.
         <br />Checksummed addresses are meant to help prevent users from sending transactions to the wrong address.
       </span>
     )
@@ -192,7 +192,7 @@ export function ContractDropdownUI (props: ContractDropdownProps) {
   const isOverSizePrompt = () => {
     return (
       <div>Contract creation initialization returns data with length of more than 24576 bytes. The deployment will likely fails. <br />
-      More info: <a href="https://github.com/ethereum/EIPs/blob/master/EIPS/eip-170.md" target="_blank">eip-170</a>
+      More info: <a href="https://github.com/ethereum/EIPs/blob/master/EIPS/eip-170.md" target="_blank" rel="noreferrer">eip-170</a>
       </div>
     )
   }

libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx

@@ -92,7 +92,7 @@ export function ContractGUI (props: ContractGUIProps) {
     let ret = ''
     const valArrayTest = []
 
-    for (var j = 0; j < valArray.length; j++) {
+    for (let j = 0; j < valArray.length; j++) {
       if (ret !== '') ret += ','
       let elVal = valArray[j] ? valArray[j].value : ''
 

libs/remix-ui/run-tab/src/lib/components/environment.tsx

@@ -30,7 +30,7 @@ export function EnvironmentUI (props: EnvironmentProps) {
             )
           }
         </select>
-        <a href="https://remix-ide.readthedocs.io/en/latest/run.html#run-setup" target="_blank"><i className="udapp_infoDeployAction ml-2 fas fa-info" title="check out docs to setup Environment"></i></a>
+        <a href="https://remix-ide.readthedocs.io/en/latest/run.html#run-setup" target="_blank" rel="noreferrer"><i className="udapp_infoDeployAction ml-2 fas fa-info" title="check out docs to setup Environment"></i></a>
       </div>
     </div>
   )

libs/remix-ui/run-tab/src/lib/components/mainnet.tsx

@@ -116,7 +116,7 @@ export function MainnetPrompt (props: MainnetProps) {
             : <div className="d-flex align-items-center my-1">
               <span className="text-dark mr-2 text-nowrap">Gas price:</span>
               <input className="form-control mr-1 text-right" style={{ width: '40px', height: '28px' }} id='gasprice' onInput={(e: any) => onGasPriceChange(e.target.value)} />
-              <span>Gwei (visit <a target='_blank' href='https://ethgasstation.info'>ethgasstation.info</a> for current gas price info.)</span>
+              <span>Gwei (visit <a target='_blank' href='https://ethgasstation.info' rel="noreferrer">ethgasstation.info</a> for current gas price info.)</span>
             </div>
         }
         <div className="mb-3">

libs/remix-ui/run-tab/src/lib/components/universalDappUI.tsx

@@ -273,7 +273,7 @@ export function UniversalDappUI (props: UdappProps) {
             <a
               href="https://solidity.readthedocs.io/en/v0.6.2/contracts.html#receive-ether-function"
               title="check out docs for using 'receive'/'fallback'"
-              target="_blank"
+              target="_blank" rel="noreferrer"
             >
               <i aria-hidden="true" className="fas fa-info my-2 mr-1"></i>
             </a>

libs/remix-ui/run-tab/src/lib/components/web3Dialog.tsx

@@ -15,16 +15,16 @@ export function Web3ProviderDialog (props: web3ProviderDialogProps) {
   return (
     <>
       <div className="">
-          Note: To use Geth & https://remix.ethereum.org, configure it to allow requests from Remix:(see <a href="https://geth.ethereum.org/docs/rpc/server" target="_blank">Geth Docs on rpc server</a>)
+          Note: To use Geth & https://remix.ethereum.org, configure it to allow requests from Remix:(see <a href="https://geth.ethereum.org/docs/rpc/server" target="_blank" rel="noreferrer">Geth Docs on rpc server</a>)
         <div className="border p-1">geth --http --http.corsdomain https://remix.ethereum.org</div>
         <br />
-        To run Remix & a local Geth test node, use this command: (see <a href="https://geth.ethereum.org/getting-started/dev-mode" target="_blank">Geth Docs on Dev mode</a>)
+        To run Remix & a local Geth test node, use this command: (see <a href="https://geth.ethereum.org/getting-started/dev-mode" target="_blank" rel="noreferrer">Geth Docs on Dev mode</a>)
         <div className="border p-1">geth --http --http.corsdomain="{window.origin}" --http.api web3,eth,debug,personal,net --vmdebug --datadir {thePath} --dev console</div>
         <br />
         <br />
         <b>WARNING:</b> It is not safe to use the --http.corsdomain flag with a wildcard: <b>--http.corsdomain *</b>
         <br />
-        <br />For more info: <a href="https://remix-ide.readthedocs.io/en/latest/run.html#more-about-web3-provider" target="_blank">Remix Docs on Web3 Provider</a>
+        <br />For more info: <a href="https://remix-ide.readthedocs.io/en/latest/run.html#more-about-web3-provider" target="_blank" rel="noreferrer">Remix Docs on Web3 Provider</a>
         <br />
         <br />
         Web3 Provider Endpoint

package.json

@@ -45,7 +45,7 @@
     "workspace-schematic": "nx workspace-schematic",
     "dep-graph": "nx dep-graph",
     "help": "nx help",
-    "lint:libs": "nx run-many --target=lint --projects=remix-analyzer,remix-astwalker,remix-debug,remix-lib,remix-simulator,remix-solidity,remix-tests,remix-url-resolver,remixd,remix-ui-tree-view,remix-ui-modal-dialog,remix-ui-toaster,remix-ui-helper,remix-ui-debugger-ui,remix-ui-workspace,remix-ui-static-analyser,remix-ui-checkbox,remix-ui-settings,remix-core-plugin,remix-ui-renderer,remix-ui-publish-to-storage,remix-ui-solidity-compiler,solidity-unit-testing,remix-ui-plugin-manager,remix-ui-terminal,remix-ui-editor,remix-ui-app,remix-ui-tabs,remix-ui-panel",
+    "lint:libs": "nx run-many --target=lint --projects=remix-analyzer,remix-astwalker,remix-debug,remix-lib,remix-simulator,remix-solidity,remix-tests,remix-url-resolver,remixd,remix-ui-tree-view,remix-ui-modal-dialog,remix-ui-toaster,remix-ui-helper,remix-ui-debugger-ui,remix-ui-workspace,remix-ui-static-analyser,remix-ui-checkbox,remix-ui-settings,remix-core-plugin,remix-ui-renderer,remix-ui-publish-to-storage,remix-ui-solidity-compiler,solidity-unit-testing,remix-ui-plugin-manager,remix-ui-terminal,remix-ui-editor,remix-ui-app,remix-ui-tabs,remix-ui-panel,remix-ui-run-tabs",
     "build:libs": "nx run-many --target=build --parallel=false --with-deps=true --projects=remix-analyzer,remix-astwalker,remix-debug,remix-lib,remix-simulator,remix-solidity,remix-tests,remix-url-resolver,remixd",
     "test:libs": "nx run-many --target=test --projects=remix-analyzer,remix-astwalker,remix-debug,remix-lib,remix-simulator,remix-solidity,remix-tests,remix-url-resolver,remixd",
     "publish:libs": "npm run build:libs && lerna publish --skip-git && npm run bumpVersion:libs",