review comment changes

pull/3023/head
Joseph Izang 2 years ago committed by Aniket
parent e99e45f158
commit b42abb7041
  1. 5
      libs/remix-ui/workspace/src/lib/css/remix-ui-workspace.css
  2. 32
      libs/remix-ui/workspace/src/lib/remix-ui-workspace.tsx

@ -51,7 +51,7 @@
word-break: break-word; word-break: break-word;
} }
.remixui_menuicon { .remixui_menuicon {
padding-right : 10px; padding-right : 30px;
} }
.remixui_menuicon:hover { .remixui_menuicon:hover {
transform: scale(1.3); transform: scale(1.3);
@ -102,3 +102,6 @@
box-shadow: 0px 0px 14px -7px; box-shadow: 0px 0px 14px -7px;
} }
.remixui_topmenu {
padding-bottom: 0.1rem;
}

@ -294,6 +294,30 @@ export function Workspace () {
} }
const workspaceMenuIcons = [ const workspaceMenuIcons = [
<OverlayTrigger
placement="top-start"
overlay={
<Tooltip id="createWorkspaceTooltip" className="text-nowrap">
<span>Create</span>
</Tooltip>
}
>
<div>
<span
hidden={currentWorkspace === LOCALHOST}
id='workspaceCreate'
data-id='workspaceCreate'
onClick={(e) => {
e.stopPropagation()
createWorkspace()
_paq.push(['trackEvent', 'fileExplorer', 'workspaceMenu', 'workspaceCreate'])
}}
className='far fa-plus remixui_menuicon'
>
</span>
<span className="pl-3">Create</span>
</div>
</OverlayTrigger>,
<OverlayTrigger <OverlayTrigger
placement='right-start' placement='right-start'
overlay={ overlay={
@ -422,7 +446,7 @@ export function Workspace () {
Workspaces Workspaces
</label> </label>
</span> </span>
<span className="remixui_menu d-flex justify-content-between align-items-end w-75"> <span className="remixui_menu remixui_topmenu d-flex justify-content-between align-items-end w-75">
<OverlayTrigger <OverlayTrigger
placement="top-start" placement="top-start"
overlay={ overlay={
@ -431,6 +455,7 @@ export function Workspace () {
</Tooltip> </Tooltip>
} }
> >
<div>
<span <span
hidden={currentWorkspace === LOCALHOST} hidden={currentWorkspace === LOCALHOST}
id='workspaceCreate' id='workspaceCreate'
@ -440,9 +465,10 @@ export function Workspace () {
createWorkspace() createWorkspace()
_paq.push(['trackEvent', 'fileExplorer', 'workspaceMenu', 'workspaceCreate']) _paq.push(['trackEvent', 'fileExplorer', 'workspaceMenu', 'workspaceCreate'])
}} }}
className='far fa-plus-square remixui_menuicon' className='far fa-plus remixui_menuicon'
> >
</span> </span>
</div>
</OverlayTrigger> </OverlayTrigger>
<Dropdown id="workspacesMenuDropdown" data-id="workspacesMenuDropdown" onToggle={() => hideIconsMenu(!showIconsMenu)} show={showIconsMenu}> <Dropdown id="workspacesMenuDropdown" data-id="workspacesMenuDropdown" onToggle={() => hideIconsMenu(!showIconsMenu)} show={showIconsMenu}>
<Dropdown.Toggle <Dropdown.Toggle
@ -452,7 +478,7 @@ export function Workspace () {
}} }}
icon={'fas fa-bars'} icon={'fas fa-bars'}
></Dropdown.Toggle> ></Dropdown.Toggle>
<Dropdown.Menu as={CustomMenu} data-id="wsdropdownMenu" className='w-100 custom-dropdown-items' align={'right'}> <Dropdown.Menu as={CustomMenu} data-id="wsdropdownMenu" className='custom-dropdown-items' align={'right'}>
{ {
workspaceMenuIcons.map(m => ( workspaceMenuIcons.map(m => (
<Dropdown.Item> <Dropdown.Item>

Loading…
Cancel
Save