Merge pull request #782 from ethereum/invalidAddress

Try catch on sendTransaction (metamask can throw)
pull/1/head
yann300 8 years ago committed by GitHub
commit b454a9a0fe
  1. 4
      src/app/execution/txRunner.js

@ -64,6 +64,7 @@ TxRunner.prototype.execute = function (args, callback) {
} }
tx.gas = gasEstimation tx.gas = gasEstimation
var sendTransaction = self.personalMode ? executionContext.web3().personal.sendTransaction : executionContext.web3().eth.sendTransaction var sendTransaction = self.personalMode ? executionContext.web3().personal.sendTransaction : executionContext.web3().eth.sendTransaction
try {
sendTransaction(tx, function (err, resp) { sendTransaction(tx, function (err, resp) {
if (err) { if (err) {
return callback(err, resp) return callback(err, resp)
@ -71,6 +72,9 @@ TxRunner.prototype.execute = function (args, callback) {
tryTillResponse(resp, callback) tryTillResponse(resp, callback)
}) })
} catch (e) {
return callback(`Send transaction failed: ${e.message} . if you use an injected provider, please check it is properly unlocked. `)
}
}) })
} }
} else { } else {

Loading…
Cancel
Save