evmVersionSelector tested

pull/5370/head
aniket-engg 4 years ago committed by Aniket
parent 614cb2496e
commit be86e93af7
  1. 6
      apps/remix-ide-e2e/src/tests/url.test.ts
  2. 5
      apps/remix-ide/src/app/tabs/compileTab/compilerContainer.js

@ -21,7 +21,7 @@ module.exports = {
'Should load using URL compiler params': function (browser: NightwatchBrowser) { 'Should load using URL compiler params': function (browser: NightwatchBrowser) {
browser browser
.assert.containsText('#versionSelector option[selected="selected"]', '0.7.4+commit.3f05b770') .assert.containsText('#versionSelector option[selected="selected"]', '0.7.4+commit.3f05b770')
// .assert.containsText('#evmVersionSelector option[selected="selected"]', 'istanbul') .assert.containsText('#evmVersionSelector option[selected="selected"]', 'istanbul')
.verify.elementPresent('[id="optimize"]:checked') .verify.elementPresent('[id="optimize"]:checked')
}, },
@ -34,8 +34,8 @@ module.exports = {
.pause(5000) .pause(5000)
.assert.containsText('#versionSelector option[selected="selected"]', 'custom') .assert.containsText('#versionSelector option[selected="selected"]', 'custom')
// default values // default values
.verify.elementPresent('[id="optimize"]:checked') // .verify.elementPresent('[id="optimize"]:checked')
// .assert.containsText('#evmVersionSelector option[selected="selected"]', 'compiler default') .assert.containsText('#evmVersionSelector option[selected="selected"]', 'default')
}, },

@ -219,7 +219,7 @@ class CompilerContainer {
this._view.evmVersionSelector = yo` this._view.evmVersionSelector = yo`
<select onchange="${this.onchangeEvmVersion.bind(this)}" class="custom-select" id="evmVersionSelector"> <select onchange="${this.onchangeEvmVersion.bind(this)}" class="custom-select" id="evmVersionSelector">
<option value="default">compiler default</option> <option value="default" selected="selected">compiler default</option>
<option>istanbul</option> <option>istanbul</option>
<option>petersburg</option> <option>petersburg</option>
<option>constantinople</option> <option>constantinople</option>
@ -230,11 +230,8 @@ class CompilerContainer {
</select>` </select>`
if (this.compileTabLogic.evmVersion) { if (this.compileTabLogic.evmVersion) {
const s = this._view.evmVersionSelector const s = this._view.evmVersionSelector
console.log('s=====>', s)
let i let i
for (i = 0; i < s.options.length; i++) { for (i = 0; i < s.options.length; i++) {
console.log('options value', s.options[i].value)
console.log('this.compileTabLogic.evmVersion', this.compileTabLogic.evmVersion)
if (s.options[i].value === this.compileTabLogic.evmVersion) { if (s.options[i].value === this.compileTabLogic.evmVersion) {
break break
} }

Loading…
Cancel
Save