resolves comments

pull/4422/head
bunsenstraat 11 months ago
parent e5a059c9ef
commit d24145b2e3
  1. 1
      apps/remix-ide/src/app/files/fileProvider.ts
  2. 5
      apps/remix-ide/src/app/plugins/electron/compilerLoaderPlugin.ts
  3. 7
      apps/remix-ide/src/app/plugins/electron/electronConfigPlugin.ts
  4. 17
      apps/remix-ide/src/app/plugins/electron/isoGitPlugin.ts
  5. 2
      apps/remix-ide/src/app/plugins/electron/templatesPlugin.ts
  6. 4
      libs/remix-ui/home-tab/src/lib/components/homeTabFeaturedPlugins.tsx

@ -287,7 +287,6 @@ export default class FileProvider {
// ^ ret does not accept path starting with '/' // ^ ret does not accept path starting with '/'
} }
} }
//console.log(`resolveDirectory ${path} took ${Date.now() - startTime} ms`)
if (cb) cb(null, ret) if (cb) cb(null, ret)
return ret return ret
} catch (error) { } catch (error) {

@ -46,11 +46,6 @@ export class compilerLoaderPlugin extends Plugin {
this.emit('jsonBinDataLoaded', response) this.emit('jsonBinDataLoaded', response)
} }
async onActivation(): Promise<void> {
}
} }
export class compilerLoaderPluginDesktop extends ElectronPlugin { export class compilerLoaderPluginDesktop extends ElectronPlugin {

@ -8,12 +8,5 @@ export class electronConfig extends ElectronPlugin {
description: 'electronconfig', description: 'electronconfig',
}) })
this.methods = [] this.methods = []
}
onActivation(): void {
} }
} }

@ -8,22 +8,5 @@ export class isoGitPlugin extends ElectronPlugin {
description: 'isogit', description: 'isogit',
}) })
this.methods = [] this.methods = []
} }
async onActivation(): Promise<void> {
setTimeout(async () => {
const version = await this.call('isogit', 'version')
if(version){
//this.call('terminal', 'log', version)
}else{
//this.call('terminal', 'log', 'Git is not installed on the system. Using builtin git instead. Performance will be affected. It is better to install git on the system and configure the credentials to connect to GitHub etc.')
}
}, 5000)
}
} }

@ -8,6 +8,4 @@ export class electronTemplates extends ElectronPlugin {
description: 'templates', description: 'templates',
}) })
} }
onActivation(): void {
}
} }

@ -74,8 +74,8 @@ function HomeTabFeaturedPlugins({plugin}: HomeTabFeaturedPluginsProps) {
} }
const startCookbook = async () => { const startCookbook = async () => {
await plugin.appManager.activatePlugin(['cookbookdev']) await plugin.appManager.activatePlugin(['cookbookdev'])
plugin.verticalIcons.select('cookbook.dev') plugin.verticalIcons.select('cookbookdev')
_paq.push(['trackEvent', 'hometabActivate', 'userActivate', 'cookbook.dev']) _paq.push(['trackEvent', 'hometabActivate', 'userActivate', 'cookbookdev'])
} }
const startSolidityUnitTesting = async () => { const startSolidityUnitTesting = async () => {
await plugin.appManager.activatePlugin(['solidity', 'solidityUnitTesting']) await plugin.appManager.activatePlugin(['solidity', 'solidityUnitTesting'])

Loading…
Cancel
Save