don't re execute render 2 times + fix plugin

pull/3094/head
yann300 7 years ago
parent 6b97da5e06
commit fd63e86a22
  1. 16
      src/app/panels/righthand-panel.js

@ -55,17 +55,19 @@ function RighthandPanel (appAPI = {}, events = {}, opts = {}) {
optionViews.appendChild(debuggerTab.render()) optionViews.appendChild(debuggerTab.render())
var supportTab = new SupportTab(appAPI, events) var supportTab = new SupportTab(appAPI, events)
optionViews.appendChild(supportTab.render()) optionViews.appendChild(supportTab.render())
this._view.tabbedMenu.addTab('Compile', 'compileView', compileTab.render()) this._view.tabbedMenu.addTab('Compile', 'compileView', optionViews.querySelector('#compileTabView'))
this._view.tabbedMenu.addTab('Run', 'runView', runTab.render()) this._view.tabbedMenu.addTab('Run', 'runView', optionViews.querySelector('#runTabView'))
this._view.tabbedMenu.addTab('Settings', 'settingsView', settingsTab.render()) this._view.tabbedMenu.addTab('Settings', 'settingsView', optionViews.querySelector('#settingsView'))
this._view.tabbedMenu.addTab('Analysis', 'staticanalysisView', analysisTab.render()) this._view.tabbedMenu.addTab('Analysis', 'staticanalysisView', optionViews.querySelector('#staticanalysisView'))
this._view.tabbedMenu.addTab('Debugger', 'debugView', debuggerTab.render()) this._view.tabbedMenu.addTab('Debugger', 'debugView', optionViews.querySelector('#debugView'))
this._view.tabbedMenu.addTab('Support', 'supportView', supportTab.render()) this._view.tabbedMenu.addTab('Support', 'supportView', optionViews.querySelector('#supportView'))
this._view.tabbedMenu.selectTabByTitle('Compile') this._view.tabbedMenu.selectTabByTitle('Compile')
self.pluginManager = new PluginManager(appAPI, events) self.pluginManager = new PluginManager(appAPI, events)
events.rhp.register('plugin-loadRequest', (json) => { events.rhp.register('plugin-loadRequest', (json) => {
var content = new PluginTab(appAPI, events, json) var tab = new PluginTab(appAPI, events, json)
var content = tab.render()
optionViews.appendChild(content)
this._view.tabbedMenu.addTab(json.title, 'plugin', content) this._view.tabbedMenu.addTab(json.title, 'plugin', content)
self.pluginManager.register(json, content) self.pluginManager.register(json, content)
}) })

Loading…
Cancel
Save