You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
296 lines
9.9 KiB
296 lines
9.9 KiB
Solidity Static Analysis
|
|
========================
|
|
|
|
Static code analysis is a process to debug the code by examining it and without actually executing the code.
|
|
|
|
`Solidity Static Analysis` plugin performs static analysis on Solidity smart contracts once they are compiled. It checks for security vulnerabilities and bad development practices, among other issues. This plugin comes with `Solidity` environment of Remix IDE. It can also be activated individually from `Plugin Manager`.
|
|
|
|
How to use
|
|
------------
|
|
|
|
If you select this plugin, you will see a number of modules listed along with checkboxes, one `Auto run` checkbox and a `Run` button.
|
|
|
|
|
|
|
|
By default, all modules are selected for analysis and a new analysis is performed at each compilation.
|
|
|
|
One can select/deselect the modules under which contract should be analyzed and can run the analysis again for last compiled contract by clicking on `Run`.
|
|
|
|
If you don't want to run analysis each time you compile a contract, just uncheck the checkbox near to `Auto run`.
|
|
|
|
Analysis Modules
|
|
-----------------
|
|
Currently, with Remix IDE v0.10.1, there are 21 analysis modules listed under 4 categories. Categories are: `Security`, `Gas & Economy`, `ERC` & `Miscellaneous`.
|
|
|
|
Here is the list of modules under each category along with the example code which **should be avoided or used very carefully while development**:
|
|
|
|
### Category: Security
|
|
- **Transaction origin: 'tx.origin' is used**
|
|
|
|
`tx.origin` is useful only in very exceptional cases. If you use it for authentication, you usually want to replace it by "msg.sender", because otherwise any contract you call can act on your behalf.
|
|
|
|
_Example:_
|
|
```
|
|
require(tx.origin == owner);
|
|
```
|
|
|
|
- **Check effects: Potential reentrancy bugs**
|
|
|
|
Potential Violation of Checks-Effects-Interaction pattern can lead to re-entrancy vulnerability.
|
|
|
|
_Example:_
|
|
```
|
|
// sending ether first
|
|
msg.sender.transfer(amount);
|
|
|
|
// updating state afterwards
|
|
balances[msg.sender] -= amount;
|
|
```
|
|
|
|
- **Inline assembly: Inline assembly used**
|
|
|
|
Use of inline assembly is advised only in rare cases.
|
|
|
|
_Example:_
|
|
```
|
|
assembly {
|
|
// retrieve the size of the code, this needs assembly
|
|
let size := extcodesize(_addr)
|
|
}
|
|
```
|
|
- **Block timestamp: Semantics maybe unclear**
|
|
|
|
`now` does not mean current time. `now` is an alias for `block.timestamp`. `block.timestamp` can be influenced by miners to a certain degree, be careful.
|
|
|
|
_Example:_
|
|
```
|
|
// using now for date comparison
|
|
if(startDate > now)
|
|
isStarted = true;
|
|
|
|
// using block.timestamp
|
|
uint c = block.timestamp;
|
|
```
|
|
- **Low level calls: Semantics maybe unclear**
|
|
|
|
Use of low level `call`, `callcode` or `delegatecall` should be avoided whenever possible. `send` does not throw an exception when not successful, make sure you deal with the failure case accordingly. Use `transfer` whenever failure of the ether transfer should rollback the whole transaction.
|
|
|
|
_Example:_
|
|
```
|
|
x.call('something');
|
|
x.send(1 wei);
|
|
```
|
|
- **Blockhash usage: Semantics maybe unclear**
|
|
|
|
`blockhash` is used to access the last 256 block hashes. A miner computes the block hash by "summing up" the information in the current block mined. By summing up the information in a clever way a miner can try to influence the outcome of a transaction in the current block.
|
|
|
|
_Example:_
|
|
```
|
|
bytes32 b = blockhash(100);
|
|
```
|
|
- **Selfdestruct: Beware of caller contracts**
|
|
|
|
`selfdestruct` can block calling contracts unexpectedly. Be especially careful if this contract is planned to be used by other contracts (i.e. library contracts, interactions). Selfdestruction of the callee contract can leave callers in an inoperable state.
|
|
|
|
_Example:_
|
|
```
|
|
selfdestruct(address(0x123abc..));
|
|
```
|
|
|
|
### Category: Gas & Economy
|
|
- **Gas costs: Too high gas requirement of functions**
|
|
|
|
If the gas requirement of a function is higher than the block gas limit, it cannot be executed. Please avoid loops in your functions or actions that modify large areas of storage
|
|
|
|
_Example:_
|
|
```
|
|
for (uint8 proposal = 0; proposal < proposals.length; proposal++) {
|
|
if (proposals[proposal].voteCount > winningVoteCount) {
|
|
winningVoteCount = proposals[proposal].voteCount;
|
|
winningProposal = proposal;
|
|
}
|
|
}
|
|
```
|
|
|
|
- **This on local calls: Invocation of local functions via 'this'**
|
|
|
|
Never use `this` to call functions in the same contract, it only consumes more gas than normal local calls.
|
|
|
|
_Example:_
|
|
```
|
|
contract test {
|
|
|
|
function callb() public {
|
|
address x;
|
|
this.b(x);
|
|
}
|
|
|
|
function b(address a) public returns (bool) {}
|
|
}
|
|
```
|
|
|
|
- **Delete on dynamic Array: Use require/assert appropriately**
|
|
|
|
The `delete` operation when applied to a dynamically sized array in Solidity generates code to delete each of the elements contained. If the array is large, this operation can surpass the block gas limit and raise an OOG exception. Also nested dynamically sized objects can produce the same results.
|
|
|
|
_Example:_
|
|
```
|
|
contract arr {
|
|
uint[] users;
|
|
function resetState() public{
|
|
delete users;
|
|
}
|
|
}
|
|
```
|
|
|
|
- **For loop over dynamic array: Iterations depend on dynamic array's size**
|
|
|
|
Loops that do not have a fixed number of iterations, for example, loops that depend on storage values, have to be used carefully: Due to the block gas limit, transactions can only consume a certain amount of gas. The number of iterations in a loop can grow beyond the block gas limit which can stall the complete contract at a certain point. Additionally, using unbounded loops can incur in a lot of avoidable gas costs. Carefully test how many items at maximum you can pass to such functions to make it successful.
|
|
|
|
_Example:_
|
|
```
|
|
contract forLoopArr {
|
|
uint[] array;
|
|
|
|
function shiftArrItem(uint index) public returns(uint[] memory) {
|
|
for (uint i = index; i < array.length; i++) {
|
|
array[i] = array[i+1];
|
|
}
|
|
return array;
|
|
}
|
|
}
|
|
```
|
|
|
|
- **Ether transfer in loop: Transferring Ether in a for/while/do-while loop**
|
|
|
|
Ether payout should not be done in a loop. Due to the block gas limit, transactions can only consume a certain amount of gas. The number of iterations in a loop can grow beyond the block gas limit which can cause the complete contract to be stalled at a certain point. If required, make sure that number of iterations are low and you trust each address involved.
|
|
|
|
_Example:_
|
|
```
|
|
contract etherTransferInLoop {
|
|
address payable owner;
|
|
|
|
function transferInForLoop(uint index) public {
|
|
for (uint i = index; i < 100; i++) {
|
|
owner.transfer(i);
|
|
}
|
|
}
|
|
|
|
function transferInWhileLoop(uint index) public {
|
|
uint i = index;
|
|
while (i < 100) {
|
|
owner.transfer(i);
|
|
i++;
|
|
}
|
|
}
|
|
}
|
|
```
|
|
|
|
### Category: ERC
|
|
- **ERC20: 'decimals' should be 'uint8'**
|
|
|
|
ERC20 Contracts `decimals` function should have `uint8` as return type.
|
|
|
|
_Example:_
|
|
```
|
|
contract EIP20 {
|
|
|
|
uint public decimals = 12;
|
|
}
|
|
```
|
|
|
|
### Category: Miscellaneous
|
|
- **Constant/View/Pure functions: Potentially constant/view/pure functions**
|
|
|
|
It warns for the methods which potentially should be constant/view/pure but are not.
|
|
|
|
_Example:_
|
|
```
|
|
function b(address a) public returns (bool) {
|
|
return true;
|
|
}
|
|
```
|
|
- **Similar variable names: Variable names are too similar**
|
|
|
|
It warns on the usage of similar variable names.
|
|
|
|
_Example:_
|
|
```
|
|
// Variables have very similar names voter and voters.
|
|
function giveRightToVote(address voter) public {
|
|
require(voters[voter].weight == 0);
|
|
voters[voter].weight = 1;
|
|
}
|
|
```
|
|
- **No return: Function with 'returns' not returning**
|
|
|
|
It warns for the methods which define a return type but never explicitly return a value.
|
|
|
|
_Example:_
|
|
```
|
|
function noreturn(string memory _dna) public returns (bool) {
|
|
dna = _dna;
|
|
}
|
|
```
|
|
- **Guard conditions: Use 'require' and 'assert' appropriately**
|
|
|
|
Use `assert(x)` if you never ever want x to be false, not in any circumstance (apart from a bug in your code). Use `require(x)` if x can be false, due to e.g. invalid input or a failing external component.
|
|
|
|
_Example:_
|
|
```
|
|
assert(a.balance == 0);
|
|
```
|
|
- **Result not used: The result of an operation not used**
|
|
|
|
A binary operation yields a value that is not used in the following. This is often caused by confusing assignment (=) and comparison (==).
|
|
|
|
_Example:_
|
|
```
|
|
c == 5;
|
|
or
|
|
a + b;
|
|
```
|
|
- **String Length: Bytes length != String length**
|
|
|
|
Bytes and string length are not the same since strings are assumed to be UTF-8 encoded (according to the ABI defintion) therefore one character is not nessesarily encoded in one byte of data.
|
|
|
|
_Example:_
|
|
```
|
|
function length(string memory a) public pure returns(uint) {
|
|
bytes memory x = bytes(a);
|
|
|
|
return x.length;
|
|
}
|
|
```
|
|
- **Delete from dynamic array: 'delete' on an array leaves a gap**
|
|
|
|
Using `delete` on an array leaves a gap. The length of the array remains the same. If you want to remove the empty position you need to shift items manually and update the length property.
|
|
|
|
_Example:_
|
|
```
|
|
contract arr {
|
|
uint[] array = [1,2,3];
|
|
|
|
function removeAtIndex() public returns (uint[] memory) {
|
|
delete array[1];
|
|
return array;
|
|
}
|
|
}
|
|
```
|
|
- **Data Truncated: Division on int/uint values truncates the result**
|
|
|
|
Division of integer values yields an integer value again. That means e.g. 10 / 100 = 0 instead of 0.1 since the result is an integer again. This does not hold for division of (only) literal values since those yield rational constants.
|
|
|
|
_Example:_
|
|
```
|
|
function contribute() payable public {
|
|
uint fee = msg.value * uint256(feePercentage / 100);
|
|
fee = msg.value * (p2 / 100);
|
|
}
|
|
```
|
|
|
|
Remix-analyzer
|
|
-----------------
|
|
`remix-analyzer` is the library which works underneath of remix-ide `Solidity Static Analysis` plugin.
|
|
|
|
`remix-analyzer` is an [NPM package](https://www.npmjs.com/package/remix-analyzer). It can be used as a library in a solution supporting node.js. Find more information about this type of usage in the [remix-analyzer repository](https://github.com/ethereum/remix/tree/master/remix-analyzer#how-to-use) |