Merge pull request #730 from testwill/loop

chore: slice replace loop

activitypub.go

@@ -648,10 +648,7 @@ func deleteFederatedPost(app *App, p *PublicPost, collID int64) error {
 
 	for si, instFolls := range inboxes {
 		na.CC = []string{}
-		for _, f := range instFolls {
+		na.CC = append(na.CC, instFolls...)
-			na.CC = append(na.CC, f)
-		}
-
 		da := activitystreams.NewDeleteActivity(na)
 		// Make the ID unique to ensure it works in Pleroma
 		// See: https://git.pleroma.social/pleroma/pleroma/issues/1481
@@ -717,9 +714,7 @@ func federatePost(app *App, p *PublicPost, collID int64, isUpdate bool) error {
 		// add all followers from that instance
 		// to the CC field
 		na.CC = []string{}
-		for _, f := range instFolls {
+		na.CC = append(na.CC, instFolls...)
-			na.CC = append(na.CC, f)
-		}
 		// create a new "Create" activity
 		// with our article as object
 		if isUpdate {

db/create.go

@@ -247,10 +247,7 @@ func (b *CreateTableSqlBuilder) ToSQL() (string, error) {
 		}
 		things = append(things, columnStr)
 	}
-	for _, constraint := range b.Constraints {
+	things = append(things, b.Constraints...)
-		things = append(things, constraint)
-	}
-
 	if thingLen := len(things); thingLen > 0 {
 		str.WriteString(" ( ")
 		for i, thing := range things {