copy over loop

common/types.go

@@ -35,10 +35,7 @@ func (h *Hash) SetBytes(b []byte) {
 		b = b[len(b)-hashLength:]
 	}
 
-	// reverse loop
+	copy(h[hashLength-len(b):], b)
-	for i := len(b) - 1; i >= 0; i-- {
-		h[hashLength-len(b)+i] = b[i]
-	}
 }
 
 // Set string `s` to h. If s is larger than len(h) it will panic
@@ -73,11 +70,7 @@ func (a *Address) SetBytes(b []byte) {
 	if len(b) > len(a) {
 		b = b[len(b)-addressLength:]
 	}
-
+	copy(a[addressLength-len(b):], b)
-	// reverse loop
-	for i := len(b) - 1; i >= 0; i-- {
-		a[addressLength-len(b)+i] = b[i]
-	}
 }
 
 // Set string `s` to a. If s is larger than len(a) it will panic

core/types/common.go

@@ -3,8 +3,8 @@ package types
 import (
 	"math/big"
 
-	"github.com/ethereum/go-ethereum/state"
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/state"
 
 	"fmt"
 )
@@ -28,10 +28,7 @@ func (b *Bloom) SetBytes(d []byte) {
 		panic(fmt.Sprintf("bloom bytes too big %d %d", len(b), len(d)))
 	}
 
-	// reverse loop
+	copy(b[bloomLength-len(d):], d)
-	for i := len(d) - 1; i >= 0; i-- {
-		b[bloomLength-len(d)+i] = b[i]
-	}
 }
 
 func (b Bloom) Big() *big.Int {