fix review comments from @ioedeveloper

pull/1671/head
Joseph Izang 3 years ago
parent 15084c1a1d
commit 7fcf4453b2
  1. 2
      apps/remix-ide-e2e/src/helpers/init.ts
  2. 1
      apps/remix-ide-e2e/src/tests/plugin_api.ts
  3. 5
      package-lock.json
  4. 1
      package.json
  5. 120
      workspace.json

@ -5,7 +5,7 @@ require('dotenv').config()
export default function (browser: NightwatchBrowser, callback: VoidFunction, url?: string, preloadPlugins = true): void { export default function (browser: NightwatchBrowser, callback: VoidFunction, url?: string, preloadPlugins = true): void {
browser browser
.url(url || 'http://127.0.0.1:8080') .url(url || 'http://127.0.0.1:8080')
.pause(10000) .pause(6000)
.switchBrowserTab(0) .switchBrowserTab(0)
.waitForElementVisible('[id="remixTourSkipbtn"]') .waitForElementVisible('[id="remixTourSkipbtn"]')
.click('[id="remixTourSkipbtn"]') .click('[id="remixTourSkipbtn"]')

@ -112,7 +112,6 @@ const clickAndCheckLog = async (browser: NightwatchBrowser, buttonText: string,
if (methodResult && typeof methodResult !== 'string') { methodResult = JSON.stringify(methodResult) } if (methodResult && typeof methodResult !== 'string') { methodResult = JSON.stringify(methodResult) }
if (eventResult && typeof eventResult !== 'string') { eventResult = JSON.stringify(eventResult) } if (eventResult && typeof eventResult !== 'string') { eventResult = JSON.stringify(eventResult) }
if (buttonText) { if (buttonText) {
console.log('this is buttonText in this test', buttonText)
await clickButton(browser, buttonText) await clickButton(browser, buttonText)
} }
await debugValues(browser, 'methods', methodResult) await debugValues(browser, 'methods', methodResult)

5
package-lock.json generated

@ -15422,11 +15422,6 @@
} }
} }
}, },
"core-js": {
"version": "3.18.2",
"resolved": "https://registry.npmjs.org/core-js/-/core-js-3.18.2.tgz",
"integrity": "sha512-zNhPOUoSgoizoSQFdX1MeZO16ORRb9FFQLts8gSYbZU5FcgXhp24iMWMxnOQo5uIaIG7/6FA/IqJPwev1o9ZXQ=="
},
"core-js-compat": { "core-js-compat": {
"version": "3.19.1", "version": "3.19.1",
"resolved": "https://registry.npmjs.org/core-js-compat/-/core-js-compat-3.19.1.tgz", "resolved": "https://registry.npmjs.org/core-js-compat/-/core-js-compat-3.19.1.tgz",

@ -161,7 +161,6 @@
"chokidar": "^2.1.8", "chokidar": "^2.1.8",
"color-support": "^1.1.3", "color-support": "^1.1.3",
"commander": "^2.20.3", "commander": "^2.20.3",
"core-js": "^3.6.5",
"deep-equal": "^1.0.1", "deep-equal": "^1.0.1",
"document-register-element": "1.13.1", "document-register-element": "1.13.1",
"ethereumjs-util": "^7.0.10", "ethereumjs-util": "^7.0.10",

@ -1099,20 +1099,6 @@
"linter": "eslint" "linter": "eslint"
} }
}, },
"@remix-ui-verticaliconspanel": {
"root": "libs/@remix-ui/verticaliconspanel",
"sourceRoot": "libs/@remix-ui/verticaliconspanel/src",
"projectType": "library",
"architect": {
"lint": {
"builder": "@nrwl/linter:eslint",
"options": {
"lintFilePatterns": [
"libs/@remix-ui/verticaliconspanel/**/*.{ts,tsx,js,jsx}"
]
}
}
},
"@nrwl/web": { "@nrwl/web": {
"application": { "application": {
"linter": "eslint" "linter": "eslint"
@ -1126,16 +1112,6 @@
"linter": "eslint" "linter": "eslint"
} }
} }
}
},
"cli": {
"defaultCollection": "@nrwl/react"
},
"schematics": {
"@nrwl/workspace": {
"library": {
"linter": "eslint"
}
}, },
"cli": { "cli": {
"defaultCollection": "@nrwl/react" "defaultCollection": "@nrwl/react"
@ -1174,99 +1150,5 @@
"linter": "eslint" "linter": "eslint"
} }
}, },
"@remix-ui-verticaliconspanel": { "defaultProject": "remix-ide"
"root": "libs/@remix-ui/verticaliconspanel",
"sourceRoot": "libs/@remix-ui/verticaliconspanel/src",
"projectType": "library",
"architect": {
"lint": {
"builder": "@nrwl/linter:eslint",
"options": {
"lintFilePatterns": [
"libs/@remix-ui/verticaliconspanel/**/*.{ts,tsx,js,jsx}"
]
}
}
},
"@nrwl/web": {
"application": {
"linter": "eslint"
}
},
"@nrwl/node": {
"application": {
"linter": "eslint"
},
"library": {
"linter": "eslint"
}
}
}
},
"cli": {
"defaultCollection": "@nrwl/react"
},
"schematics": {
"@nrwl/workspace": {
"library": {
"linter": "eslint"
}
},
"@nrwl/cypress": {
"cypress-project": {
"linter": "eslint"
}
},
"@nrwl/react": {
"application": {
"style": "css",
"linter": "eslint",
"babel": true
},
"component": {
"style": "css"
},
"library": {
"style": "css",
"linter": "eslint"
}
},
"@nrwl/next": {
"application": {
"linter": "eslint"
}
},
"@nrwl/web": {
"application": {
"linter": "eslint"
}
},
"@nrwl/node": {
"application": {
"linter": "eslint"
},
"library": {
"linter": "eslint"
}
},
"@nrwl/nx-plugin": {
"plugin": {
"linter": "eslint"
}
},
"@nrwl/nest": {
"application": {
"linter": "eslint"
}
},
"@nrwl/express": {
"application": {
"linter": "eslint"
},
"library": {
"linter": "eslint"
}
}
},
"defaultProject": "remix-ide"
} }

Loading…
Cancel
Save